[v3,5/7] arm: juno: Use PSCI based reset

Message ID 20200427181804.15787-6-andre.przywara@arm.com
State Superseded
Headers show
Series
  • Arm Juno board OF_CONTROL upgrade
Related show

Commit Message

Andre Przywara April 27, 2020, 6:18 p.m.
So far the Juno board wasn't implementing reset. Let's just use the
already existing PSCI_RESET based method to avoid any extra code.

Signed-off-by: Andre Przywara <andre.przywara at arm.com>
Acked-by: Liviu Dudau <liviu.dudau at arm.com>
---
 arch/arm/Kconfig                     | 2 ++
 board/armltd/vexpress64/vexpress64.c | 4 +---
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Simon Glass April 28, 2020, 5:57 p.m. | #1
On Mon, 27 Apr 2020 at 12:19, Andre Przywara <andre.przywara at arm.com> wrote:
>
> So far the Juno board wasn't implementing reset. Let's just use the
> already existing PSCI_RESET based method to avoid any extra code.
>
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> Acked-by: Liviu Dudau <liviu.dudau at arm.com>
> ---
>  arch/arm/Kconfig                     | 2 ++
>  board/armltd/vexpress64/vexpress64.c | 4 +---
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>
Tom Rini May 7, 2020, 1:03 p.m. | #2
On Mon, Apr 27, 2020 at 07:18:02PM +0100, Andre Przywara wrote:

> So far the Juno board wasn't implementing reset. Let's just use the
> already existing PSCI_RESET based method to avoid any extra code.
> 
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> Acked-by: Liviu Dudau <liviu.dudau at arm.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index cf8b629c0e..449ef06be5 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1138,6 +1138,8 @@  config TARGET_VEXPRESS64_JUNO
 	select OF_BOARD
 	select CLK
 	select DM_SERIAL
+	select ARM_PSCI_FW
+	select PSCI_RESET
 
 config TARGET_LS2080A_EMU
 	bool "Support ls2080a_emu"
diff --git a/board/armltd/vexpress64/vexpress64.c b/board/armltd/vexpress64/vexpress64.c
index ba49b32e58..5c7a8f55f0 100644
--- a/board/armltd/vexpress64/vexpress64.c
+++ b/board/armltd/vexpress64/vexpress64.c
@@ -139,9 +139,7 @@  void *board_fdt_blob_setup(void)
 }
 #endif
 
-/*
- * Board specific reset that is system reset.
- */
+/* Actual reset is done via PSCI. */
 void reset_cpu(ulong addr)
 {
 }