diff mbox series

[v2,1/1] lib: Kconfig dependencies for pseudo-random library

Message ID 20200119182812.77417-1-xypron.glpk@gmx.de
State Accepted
Commit 1611235b858abe08f9267f1fa95bc7553aa8e644
Headers show
Series [v2,1/1] lib: Kconfig dependencies for pseudo-random library | expand

Commit Message

Heinrich Schuchardt Jan. 19, 2020, 6:28 p.m. UTC
drivers/rng/sandbox_rng.c requires rand() to be defined but configuration
option CONFIG_CONFIG_LIB_RAND selected in drivers/rng/Kconfig does not
exist.

test/lib/test_aes.c requires rand() to be defined.

Fix the selection criteria for choice "Pseudo-random library support type".

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
v2:
	fix typo in title
---
 drivers/rng/Kconfig | 1 -
 lib/Kconfig         | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.24.1

Comments

Tom Rini Jan. 25, 2020, 5:09 p.m. UTC | #1
On Sun, Jan 19, 2020 at 07:28:12PM +0100, Heinrich Schuchardt wrote:

> drivers/rng/sandbox_rng.c requires rand() to be defined but configuration
> option CONFIG_CONFIG_LIB_RAND selected in drivers/rng/Kconfig does not
> exist.
> 
> test/lib/test_aes.c requires rand() to be defined.
> 
> Fix the selection criteria for choice "Pseudo-random library support type".
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/rng/Kconfig b/drivers/rng/Kconfig
index 35a3bd192a..893b89d49b 100644
--- a/drivers/rng/Kconfig
+++ b/drivers/rng/Kconfig
@@ -9,7 +9,6 @@  config DM_RNG
 config RNG_SANDBOX
 	bool "Sandbox random number generator"
 	depends on SANDBOX && DM_RNG
-	select CONFIG_LIB_RAND
 	help
 	  Enable random number generator for sandbox. This is an
 	  emulation of a rng device.
diff --git a/lib/Kconfig b/lib/Kconfig
index d040a87d26..ab6aff710d 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -150,7 +150,8 @@  config REGEX

 choice
 	prompt "Pseudo-random library support type"
-	depends on NET_RANDOM_ETHADDR || RANDOM_UUID || CMD_UUID
+	depends on NET_RANDOM_ETHADDR || RANDOM_UUID || CMD_UUID || \
+		   RNG_SANDBOX || UT_LIB && AES
 	default LIB_RAND
 	help
 	  Select the library to provide pseudo-random number generator