U-Boot Logo showing incorrect colors with eLCDIF

Hi Anatolij,

On Thu, Jan 23, 2020 at 11:36 AM Anatolij Gustschin <agust at denx.de> wrote:

> Do you have 'bits-per-pixel' property in your display node in DT?
> Is suitable CONFIG_VIDEO_BPPxx option enabled in your board_defconfig ?

Yes, I have it, but it has the wrong value. It should be 24bpp instead of 16bpp.

I did the following change:


And now I see the U-Boot strings showing with a correct white color.

However, the logo does not print and I have the following error:

Error: 32 bit/pixel mode, but BMP has 8 bit/pixel

How can I fix this mismatch?

Thanks

Hi Fabio,

On Fri, 24 Jan 2020 16:26:26 -0300
Fabio Estevam festevam at gmail.com wrote:

> > Do you have 'bits-per-pixel' property in your display node in DT?
> > Is suitable CONFIG_VIDEO_BPPxx option enabled in your board_defconfig ?  
> 
> Yes, I have it, but it has the wrong value. It should be 24bpp instead of 16bpp.
> 
> I did the following change:
> 
> --- a/arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi
> @@ -4,7 +4,6 @@
>   */
> 
>         display0: display at 0 {
> -               bits-per-pixel = <16>;
> +               bits-per-pixel = <24>;
>                 bus-width = <24>;
> 
>                 display-timings {
> 
> And now I see the U-Boot strings showing with a correct white color.
> 
> However, the logo does not print and I have the following error:
> 
> Error: 32 bit/pixel mode, but BMP has 8 bit/pixel
> 
> How can I fix this mismatch?

Now I see that bitmap rendering code for video-uclass driver
doesn't support displaying 8bpp bitmaps on 24bpp frame buffer.

Before DM_VIDEO conversion cfb_console driver was used and
it supports such rendering. I'm working on a fix for this.
Thanks for testing!

--
Anatolij

Hi Anatolij,

On Sat, Jan 25, 2020 at 3:36 PM Anatolij Gustschin <agust at denx.de> wrote:

> Now I see that bitmap rendering code for video-uclass driver
> doesn't support displaying 8bpp bitmaps on 24bpp frame buffer.
>
> Before DM_VIDEO conversion cfb_console driver was used and
> it supports such rendering. I'm working on a fix for this.
> Thanks for testing!

Excellent, I will be glad to test it when you have it ready.

I think this is the last remaining issue with mxsfb DM_VIDEO conversion.

Thanks!

Hi Fabio,

On Mon, 24 Feb 2020 09:38:04 -0300
Fabio Estevam festevam at gmail.com wrote:

> Hi Anatolij,
> 
> On Wed, Feb 5, 2020 at 2:45 PM Fabio Estevam <festevam at gmail.com> wrote:
> >
> > Hi Anatolij,
> >
> > On Wed, Feb 5, 2020 at 2:00 PM Anatolij Gustschin <agust at denx.de> wrote:
> >  
> > > I tried to extend the BMP code to fix this, but my testing with
> > > sandbox SDL end of last week has shown incorrect colors in 24bpp
> > > mode, and I didn't find the reason for it. I do not see what is
> > > wrong in the code, maybe there is some issue with sandbox SDL.
> > > So I've submitted some patches [1], [2], [3]. Could you please
> > > test them on mx6ul-14x14-evk ? Thanks!  
> >
> > Thanks for the patches.
> >
> > I can see the logo colors correctly now, but there is some breakage now.
> >
> > Please see the result at:
> > https://ibb.co/0YKwTxJ  
> 
> Would you have a fix for this?

I've tested on mx6ul-14x14-evk, with current U-Boot master I do not
see this problem any more.

--
Anatolij

Hi Anatolij,

On Mon, Jun 29, 2020 at 4:31 AM Anatolij Gustschin <agust at denx.de> wrote:

> I've tested on mx6ul-14x14-evk, with current U-Boot master I do not
> see this problem any more.

Excellent! I saw Ye Li's patches that fixed the problem.

Thanks