| Message ID | 20200126225009.7362-4-mrjoel@lixil.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ClearFog Base static variant support | expand |
Hi Joel, On Mon, Jan 27 2020, Joel Johnson wrote: > Make the board version printed indicate the Pro variant default. > Also adjust static name casing to match what is expected for > EEPROM product name to share string constants. > > --- > > > Baruch - can you confirm expected/desired branding casing? The SolidRun > website and prior to this commit uses "ClearFog", however the EEPROM > checked values use "Clearfog", so I changed to match to be able to use > the same string constant values for consistency. I am fine with this change. The official name is "ClearFog", but you can also find "Clearfog" in the documentation, for example: https://developer.solid-run.com/knowledge-base/a388-debian/ baruch > Signed-off-by: Joel Johnson <mrjoel at lixil.net> > --- > board/solidrun/clearfog/clearfog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c > index e268ef55a2..9b31902c70 100644 > --- a/board/solidrun/clearfog/clearfog.c > +++ b/board/solidrun/clearfog/clearfog.c > @@ -170,7 +170,7 @@ int board_init(void) > > int checkboard(void) > { > - char *board = "ClearFog"; > + char *board = "Clearfog Pro"; > > cf_read_tlv_data(); > if (strlen(cf_tlv_data.tlv_product_name[0]) > 0)
diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c index e268ef55a2..9b31902c70 100644 --- a/board/solidrun/clearfog/clearfog.c +++ b/board/solidrun/clearfog/clearfog.c @@ -170,7 +170,7 @@ int board_init(void) int checkboard(void) { - char *board = "ClearFog"; + char *board = "Clearfog Pro"; cf_read_tlv_data(); if (strlen(cf_tlv_data.tlv_product_name[0]) > 0)
Make the board version printed indicate the Pro variant default. Also adjust static name casing to match what is expected for EEPROM product name to share string constants. --- Baruch - can you confirm expected/desired branding casing? The SolidRun website and prior to this commit uses "ClearFog", however the EEPROM checked values use "Clearfog", so I changed to match to be able to use the same string constant values for consistency. Signed-off-by: Joel Johnson <mrjoel at lixil.net> --- board/solidrun/clearfog/clearfog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)