| Message ID | 20200131133947.35583-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Accepted |
| Commit | 289dd9f0720dbbefd6092b9388ad60cc42cb358a |
| Headers | show |
| Series | serial_lpuart: make clock failure less verbose | expand |
On Fri, 31 Jan 2020 at 06:39, Giulio Benetti <giulio.benetti at benettiengineering.com> wrote: > > Some device may enable CONFIG_CLK but not still support this clock in > CC, so better use debug() in place of dev_warn() otherwise a lot of > boards will throw useless dev_warn()s. > > Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com> > --- > drivers/serial/serial_lpuart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg at chromium.org>
Hi Lukasz, On 1/31/20 7:14 PM, Simon Glass wrote: > On Fri, 31 Jan 2020 at 06:39, Giulio Benetti > <giulio.benetti at benettiengineering.com> wrote: >> >> Some device may enable CONFIG_CLK but not still support this clock in >> CC, so better use debug() in place of dev_warn() otherwise a lot of ^^ this must be CCF. Can you correct commit log while applying? Thanks in advance
> Some device may enable CONFIG_CLK but not still support this clock in > CC, so better use debug() in place of dev_warn() otherwise a lot of > boards will throw useless dev_warn()s. > Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com> > Reviewed-by: Simon Glass <sjg at chromium.org> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/drivers/serial/serial_lpuart.c b/drivers/serial/serial_lpuart.c index ccb3ce6701..1087dc3b65 100644 --- a/drivers/serial/serial_lpuart.c +++ b/drivers/serial/serial_lpuart.c @@ -498,7 +498,7 @@ static int lpuart_serial_probe(struct udevice *dev) return ret; } } else { - dev_warn(dev, "Failed to get per clk: %d\n", ret); + debug("%s: Failed to get per clk: %d\n", __func__, ret); } #endif
Some device may enable CONFIG_CLK but not still support this clock in CC, so better use debug() in place of dev_warn() otherwise a lot of boards will throw useless dev_warn()s. Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com> --- drivers/serial/serial_lpuart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)