diff mbox series

ARM: dts: stm32mp: remove hnp-srp-disable for usbotg on dk1

Message ID 20200701111010.21586-1-patrick.delaunay@st.com
State Accepted
Commit 7ecbefd3ec05e4ed1eeb933e25f041d50b23d823
Headers show
Series ARM: dts: stm32mp: remove hnp-srp-disable for usbotg on dk1 | expand

Commit Message

Patrick Delaunay July 1, 2020, 11:10 a.m. UTC
Remove hnp-srp-disable for usbotg node because this feature is only needed
for usbotg in HOST mode (in drivers/usb/host/dwc2.c)
and this feature is not activated in stm32mp15 U-Boot
(stm32mp15_basic_defconfig and stm32mp15_trusted_defconfig);
only the device mode is activated and OTG is not supported in DWC2 driver.

This patch reduces the difference between U-Boot and Linux kernel
device-tree.

Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
---

 arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Patrice CHOTARD July 2, 2020, 8:19 a.m. UTC | #1
Hi Patrick

On 7/1/20 1:10 PM, Patrick Delaunay wrote:
> Remove hnp-srp-disable for usbotg node because this feature is only needed
> for usbotg in HOST mode (in drivers/usb/host/dwc2.c)
> and this feature is not activated in stm32mp15 U-Boot
> (stm32mp15_basic_defconfig and stm32mp15_trusted_defconfig);
> only the device mode is activated and OTG is not supported in DWC2 driver.
>
> This patch reduces the difference between U-Boot and Linux kernel
> device-tree.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
>  arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
> index e13dade463..6e4e4922ab 100644
> --- a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
> +++ b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
> @@ -203,5 +203,4 @@
>  
>  &usbotg_hs {
>  	u-boot,force-b-session-valid;
> -	hnp-srp-disable;
>  };

Reviewed-by: Patrice Chotard <patrice.chotard at st.com>

Thanks
Patrice CHOTARD July 28, 2020, 4:11 p.m. UTC | #2
On 7/2/20 10:19 AM, Patrice CHOTARD wrote:
> Hi Patrick

>

> On 7/1/20 1:10 PM, Patrick Delaunay wrote:

>> Remove hnp-srp-disable for usbotg node because this feature is only needed

>> for usbotg in HOST mode (in drivers/usb/host/dwc2.c)

>> and this feature is not activated in stm32mp15 U-Boot

>> (stm32mp15_basic_defconfig and stm32mp15_trusted_defconfig);

>> only the device mode is activated and OTG is not supported in DWC2 driver.

>>

>> This patch reduces the difference between U-Boot and Linux kernel

>> device-tree.

>>

>> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>

>> ---

>>

>>  arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 1 -

>>  1 file changed, 1 deletion(-)

>>

>> diff --git a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi

>> index e13dade463..6e4e4922ab 100644

>> --- a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi

>> +++ b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi

>> @@ -203,5 +203,4 @@

>>  

>>  &usbotg_hs {

>>  	u-boot,force-b-session-valid;

>> -	hnp-srp-disable;

>>  };

> Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

>

> Thanks

> _______________________________________________

> Uboot-stm32 mailing list

> Uboot-stm32@st-md-mailman.stormreply.com

> https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32

Applied to u-boot-stm/master

Thanks

Patrice
diff mbox series

Patch

diff --git a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
index e13dade463..6e4e4922ab 100644
--- a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
@@ -203,5 +203,4 @@ 
 
 &usbotg_hs {
 	u-boot,force-b-session-valid;
-	hnp-srp-disable;
 };