| Message ID | 20200704174248.43108-1-masahiroy@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | x86: remove unused setup_pcat_compatibility() stub | expand |
Hi Masahiro, On Sat, 4 Jul 2020 at 11:43, Masahiro Yamada <masahiroy at kernel.org> wrote: > > 'git grep' did not find any user of this stub. > > Signed-off-by: Masahiro Yamada <masahiroy at kernel.org> > --- > > arch/x86/include/asm/u-boot-x86.h | 2 -- > arch/x86/lib/zimage.c | 10 ---------- > 2 files changed, 12 deletions(-) > See also: http://patchwork.ozlabs.org/project/uboot/patch/20200615035738.248710-21-sjg at chromium.org/ Regards, Simon
Simon, On Tue, Jul 7, 2020 at 3:44 AM Simon Glass <sjg at chromium.org> wrote: > > Hi Masahiro, > > On Sat, 4 Jul 2020 at 11:43, Masahiro Yamada <masahiroy at kernel.org> wrote: > > > > 'git grep' did not find any user of this stub. > > > > Signed-off-by: Masahiro Yamada <masahiroy at kernel.org> > > --- > > > > arch/x86/include/asm/u-boot-x86.h | 2 -- > > arch/x86/lib/zimage.c | 10 ---------- > > 2 files changed, 12 deletions(-) > > > > See also: http://patchwork.ozlabs.org/project/uboot/patch/20200615035738.248710-21-sjg at chromium.org/ That's fine if you are removing this function. Thanks.
On Tue, Jul 7, 2020 at 10:08 AM Masahiro Yamada <masahiroy at kernel.org> wrote: > > Simon, > > On Tue, Jul 7, 2020 at 3:44 AM Simon Glass <sjg at chromium.org> wrote: > > > > Hi Masahiro, > > > > On Sat, 4 Jul 2020 at 11:43, Masahiro Yamada <masahiroy at kernel.org> wrote: > > > > > > 'git grep' did not find any user of this stub. > > > > > > Signed-off-by: Masahiro Yamada <masahiroy at kernel.org> > > > --- > > > > > > arch/x86/include/asm/u-boot-x86.h | 2 -- > > > arch/x86/lib/zimage.c | 10 ---------- > > > 2 files changed, 12 deletions(-) > > > > > > > See also: http://patchwork.ozlabs.org/project/uboot/patch/20200615035738.248710-21-sjg at chromium.org/ > > > That's fine if you are removing this function. > > Thanks. Thanks Masahiro. I will use Simon's version then as it is included in a series. Regards, Bin
diff --git a/arch/x86/include/asm/u-boot-x86.h b/arch/x86/include/asm/u-boot-x86.h index 3e5d56d075..054203584b 100644 --- a/arch/x86/include/asm/u-boot-x86.h +++ b/arch/x86/include/asm/u-boot-x86.h @@ -75,8 +75,6 @@ int default_print_cpuinfo(void); /* Set up a UART which can be used with printch(), printhex8(), etc. */ int setup_internal_uart(int enable); -void setup_pcat_compatibility(void); - void isa_unmap_rom(u32 addr); u32 isa_map_rom(u32 bus_addr, int size); diff --git a/arch/x86/lib/zimage.c b/arch/x86/lib/zimage.c index 64d14e8911..d2b6002008 100644 --- a/arch/x86/lib/zimage.c +++ b/arch/x86/lib/zimage.c @@ -304,13 +304,6 @@ int setup_zimage(struct boot_params *setup_base, char *cmd_line, int auto_boot, return 0; } -void setup_pcat_compatibility(void) - __attribute__((weak, alias("__setup_pcat_compatibility"))); - -void __setup_pcat_compatibility(void) -{ -} - int do_zboot(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { struct boot_params *base_ptr; @@ -323,9 +316,6 @@ int do_zboot(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) disable_interrupts(); - /* Setup board for maximum PC/AT Compatibility */ - setup_pcat_compatibility(); - if (argc >= 2) { /* argv[1] holds the address of the bzImage */ s = argv[1];
'git grep' did not find any user of this stub. Signed-off-by: Masahiro Yamada <masahiroy at kernel.org> --- arch/x86/include/asm/u-boot-x86.h | 2 -- arch/x86/lib/zimage.c | 10 ---------- 2 files changed, 12 deletions(-)