| Message ID | 20200613205717.v2.36.I21d414dc01a25946e241231d1f3c75c890303cf1@changeid |
|---|---|
| State | Accepted |
| Commit | bdca932f5bd9db85a4d66454a2399be8ffa96461 |
| Headers | show |
| Series | rockchip: x86: Support building ROM files automatically with binman | expand |
On Sun, Jun 14, 2020 at 10:58 AM Simon Glass <sjg at chromium.org> wrote: > > On tegra various files that need to be created by binman. It does not make > sense to enumerate these in the Makefile. They are described in the > configuration (devicetree) for each board and we can simply run binman > (always) to generate them. > > This avoid sprinkling the Makefile with arch-specific code. > > Signed-off-by: Simon Glass <sjg at chromium.org> > --- > > (no changes since v1) > > Makefile | 12 ------------ > 1 file changed, 12 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
diff --git a/Makefile b/Makefile index ac628cc772..19c6ca53f7 100644 --- a/Makefile +++ b/Makefile @@ -921,12 +921,6 @@ ifeq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64)$(CONFIG_SPL),yyy) INPUTS-y += u-boot-sunxi-with-spl.bin endif -# enable combined SPL/u-boot/dtb rules for tegra -ifeq ($(CONFIG_ARCH_TEGRA)$(CONFIG_SPL),yy) -INPUTS-y += u-boot-tegra.bin u-boot-nodtb-tegra.bin -INPUTS-$(CONFIG_OF_SEPARATE) += u-boot-dtb-tegra.bin -endif - INPUTS-$(CONFIG_ARCH_MEDIATEK) += u-boot-mtk.bin # Add optional build target if defined in board/cpu/soc headers @@ -1607,12 +1601,6 @@ u-boot-sunxi-with-spl.bin: spl/sunxi-spl.bin u-boot.itb FORCE endif endif -ifneq ($(CONFIG_ARCH_TEGRA),) -# Makes u-boot-dtb-tegra.bin u-boot-tegra.bin u-boot-nodtb-tegra.bin -%-dtb-tegra.bin %-tegra.bin %-nodtb-tegra.bin: spl/%-spl %.bin FORCE - $(call if_changed,binman) -endif - OBJCOPYFLAGS_u-boot-app.efi := $(OBJCOPYFLAGS_EFI) u-boot-app.efi: u-boot FORCE $(call if_changed,zobjcopy)
On tegra various files that need to be created by binman. It does not make sense to enumerate these in the Makefile. They are described in the configuration (devicetree) for each board and we can simply run binman (always) to generate them. This avoid sprinkling the Makefile with arch-specific code. Signed-off-by: Simon Glass <sjg at chromium.org> --- (no changes since v1) Makefile | 12 ------------ 1 file changed, 12 deletions(-)