diff mbox series

arm: k3: Consolidate and silence k3_fit_atf.sh call

Message ID 3efc269b-d806-5bcd-a464-af0fc8b39a9f@siemens.com
State Accepted
Commit dde9da82d65c23e9bdc0d0293c762f86db9b63af
Headers show
Series arm: k3: Consolidate and silence k3_fit_atf.sh call | expand

Commit Message

Jan Kiszka June 25, 2020, 6:43 a.m. UTC
From: Jan Kiszka <jan.kiszka at siemens.com>

Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
---
 arch/arm/mach-k3/config.mk | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

Comments

Lokesh Vutla June 29, 2020, 2:09 a.m. UTC | #1
On 25/06/20 12:13 pm, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka at siemens.com>
> 
> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>

Thanks for cleaning ti up Jan. May be a small commit message would help.

Other that that:

Acked-by: Lokesh Vutla <lokeshvutla at ti.com>

Thanks and regards,
Lokesh

> ---
>  arch/arm/mach-k3/config.mk | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/mach-k3/config.mk b/arch/arm/mach-k3/config.mk
> index f6b63db349..f7afef610c 100644
> --- a/arch/arm/mach-k3/config.mk
> +++ b/arch/arm/mach-k3/config.mk
> @@ -48,22 +48,23 @@ ALL-y	+= tiboot3.bin
>  endif
>  
>  ifdef CONFIG_ARM64
> +
>  ifeq ($(CONFIG_TI_SECURE_DEVICE),y)
>  SPL_ITS := u-boot-spl-k3_HS.its
> -$(SPL_ITS): FORCE
> -	IS_HS=1 \
> -	$(srctree)/tools/k3_fit_atf.sh \
> -	$(patsubst %,$(obj)/dts/%.dtb,$(subst ",,$(CONFIG_SPL_OF_LIST))) > $@
> -
> +$(SPL_ITS): export IS_HS=1
>  ALL-y	+= tispl.bin_HS
>  else
>  SPL_ITS := u-boot-spl-k3.its
> -$(SPL_ITS): FORCE
> +ALL-y	+= tispl.bin
> +endif
> +
> +quiet_cmd_k3_mkits = MKITS   $@
> +cmd_k3_mkits = \
>  	$(srctree)/tools/k3_fit_atf.sh \
>  	$(patsubst %,$(obj)/dts/%.dtb,$(subst ",,$(CONFIG_SPL_OF_LIST))) > $@
>  
> -ALL-y	+= tispl.bin
> -endif
> +$(SPL_ITS): FORCE
> +	$(call cmd,k3_mkits)
>  endif
>  
>  else
>
Lokesh Vutla June 29, 2020, 2:12 a.m. UTC | #2
On 25/06/20 12:13 pm, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka at siemens.com>
> 
> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>

Thanks for cleaning it up Jan. May be a small commit message would be really useful.

Other than that:

Acked-by: Lokesh Vutla <lokeshvutla at ti.com>

Thanks and regards,
Lokesh
diff mbox series

Patch

diff --git a/arch/arm/mach-k3/config.mk b/arch/arm/mach-k3/config.mk
index f6b63db349..f7afef610c 100644
--- a/arch/arm/mach-k3/config.mk
+++ b/arch/arm/mach-k3/config.mk
@@ -48,22 +48,23 @@  ALL-y	+= tiboot3.bin
 endif
 
 ifdef CONFIG_ARM64
+
 ifeq ($(CONFIG_TI_SECURE_DEVICE),y)
 SPL_ITS := u-boot-spl-k3_HS.its
-$(SPL_ITS): FORCE
-	IS_HS=1 \
-	$(srctree)/tools/k3_fit_atf.sh \
-	$(patsubst %,$(obj)/dts/%.dtb,$(subst ",,$(CONFIG_SPL_OF_LIST))) > $@
-
+$(SPL_ITS): export IS_HS=1
 ALL-y	+= tispl.bin_HS
 else
 SPL_ITS := u-boot-spl-k3.its
-$(SPL_ITS): FORCE
+ALL-y	+= tispl.bin
+endif
+
+quiet_cmd_k3_mkits = MKITS   $@
+cmd_k3_mkits = \
 	$(srctree)/tools/k3_fit_atf.sh \
 	$(patsubst %,$(obj)/dts/%.dtb,$(subst ",,$(CONFIG_SPL_OF_LIST))) > $@
 
-ALL-y	+= tispl.bin
-endif
+$(SPL_ITS): FORCE
+	$(call cmd,k3_mkits)
 endif
 
 else