| Message ID | 20200630165650.9540-2-trini@konsulko.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] am335x: Update list of defconfigs | expand |
On Tue, Jun 30, 2020 at 11:56 AM Tom Rini <trini at konsulko.com> wrote: > > Disable USB support for now. There is non-trivial work required to > fully move the OMAP3 platforms to DM. While this work is in-progress, > disable USB support for now as we've gone well past the migration > deadline. > > Cc: Adam Ford <aford173 at gmail.com> > Signed-off-by: Tom Rini <trini at konsulko.com> > --- I don't have a beagle, but I have DM_USB working on two different OMAP3 boards. I am curious to know what's left or what's not working. adam > configs/omap3_beagle_defconfig | 20 ++------------------ > 1 file changed, 2 insertions(+), 18 deletions(-) > > diff --git a/configs/omap3_beagle_defconfig b/configs/omap3_beagle_defconfig > index ed7cb8f2ff63..236a4f4f5f5a 100644 > --- a/configs/omap3_beagle_defconfig > +++ b/configs/omap3_beagle_defconfig > @@ -9,6 +9,7 @@ CONFIG_NR_DRAM_BANKS=2 > CONFIG_SPL=y > CONFIG_SPL_TEXT_BASE=0x40200000 > CONFIG_DISTRO_DEFAULTS=y > +CONFIG_ANDROID_BOOT_IMAGE=y > CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd" > CONFIG_USE_PREBOOT=y > CONFIG_PREBOOT="usb start" > @@ -31,7 +32,6 @@ CONFIG_CMD_MMC=y > CONFIG_CMD_NAND=y > CONFIG_CMD_NAND_TRIMFFS=y > CONFIG_CMD_SPI=y > -CONFIG_CMD_USB=y > CONFIG_CMD_CACHE=y > CONFIG_CMD_EXT4_WRITE=y > CONFIG_CMD_FS_UUID=y > @@ -50,8 +50,6 @@ CONFIG_ENV_IS_IN_NAND=y > CONFIG_SPL_DM=y > CONFIG_SPL_DM_SEQ_ALIAS=y > CONFIG_SPL_OF_TRANSLATE=y > -CONFIG_USB_FUNCTION_FASTBOOT=y > -CONFIG_FASTBOOT_BUF_ADDR=0x82000000 > CONFIG_LED_STATUS=y > CONFIG_LED_STATUS0=y > CONFIG_LED_STATUS_BIT=1 > @@ -73,24 +71,10 @@ CONFIG_SYS_NAND_BUSWIDTH_16BIT=y > CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y > CONFIG_SYS_NAND_U_BOOT_OFFS=0x80000 > CONFIG_SPL_NAND_SIMPLE=y > +CONFIG_DM_ETH=y > CONFIG_SPI=y > CONFIG_DM_SPI=y > CONFIG_OMAP3_SPI=y > -CONFIG_USB=y > -CONFIG_USB_EHCI_HCD=y > -CONFIG_USB_OMAP3=y > -CONFIG_USB_MUSB_GADGET=y > -CONFIG_USB_MUSB_OMAP2PLUS=y > -CONFIG_TWL4030_USB=y > -CONFIG_USB_GADGET=y > -CONFIG_USB_GADGET_MANUFACTURER="TI" > -CONFIG_USB_GADGET_VENDOR_NUM=0x0451 > -CONFIG_USB_GADGET_PRODUCT_NUM=0xd022 > -CONFIG_USB_ETHER=y > -CONFIG_USB_HOST_ETHER=y > -CONFIG_USB_ETHER_ASIX=y > -CONFIG_USB_ETHER_MCS7830=y > -CONFIG_USB_ETHER_SMSC95XX=y > CONFIG_VIDEO_OMAP3=y > CONFIG_FAT_WRITE=y > CONFIG_BCH=y > -- > 2.17.1 >
On Tue, Jun 30, 2020 at 12:07:51PM -0500, Adam Ford wrote: > On Tue, Jun 30, 2020 at 11:56 AM Tom Rini <trini at konsulko.com> wrote: > > > > Disable USB support for now. There is non-trivial work required to > > fully move the OMAP3 platforms to DM. While this work is in-progress, > > disable USB support for now as we've gone well past the migration > > deadline. > > > > Cc: Adam Ford <aford173 at gmail.com> > > Signed-off-by: Tom Rini <trini at konsulko.com> > > --- > > I don't have a beagle, but I have DM_USB working on two different > OMAP3 boards. I am curious to know what's left or what's not working. Oh? I thought when we talked last there was still more to do to fully migrate things over. Where should I check again to see what I need to do on beagle to convert it over? Thanks!
On Tue, Jun 30, 2020 at 12:14 PM Tom Rini <trini at konsulko.com> wrote: > > On Tue, Jun 30, 2020 at 12:07:51PM -0500, Adam Ford wrote: > > On Tue, Jun 30, 2020 at 11:56 AM Tom Rini <trini at konsulko.com> wrote: > > > > > > Disable USB support for now. There is non-trivial work required to > > > fully move the OMAP3 platforms to DM. While this work is in-progress, > > > disable USB support for now as we've gone well past the migration > > > deadline. > > > > > > Cc: Adam Ford <aford173 at gmail.com> > > > Signed-off-by: Tom Rini <trini at konsulko.com> > > > --- > > > > I don't have a beagle, but I have DM_USB working on two different > > OMAP3 boards. I am curious to know what's left or what's not working. > > Oh? I thought when we talked last there was still more to do to fully > migrate things over. Where should I check again to see what I need to > do on beagle to convert it over? Thanks! With [1], the DM support for the EHCI controller was added. There is still some work to be done to make it better, because there are still some #defines that need to assign the reset GPIO's. Ideally we'd get rid of the GPIO defines and use the device tree to address the reset. It isn't perfect, but it's better than having no USB at all. The am3517_evm and omap3_logic_somlv have them working. Make sure the board files have the legacy USB stuff removed [2] [1] - https://gitlab.denx.de/u-boot/u-boot/-/commit/94ed66194f150c308d1713965a28abce3ac6e200 [2] - https://gitlab.denx.de/u-boot/u-boot/-/commit/76f6d52e61a1968702af69d6cea463b9d9332a96 Let me know if there is anything I can do to help. adam > > -- > Tom
On Tue, Jun 30, 2020 at 12:35:31PM -0500, Adam Ford wrote: > On Tue, Jun 30, 2020 at 12:14 PM Tom Rini <trini at konsulko.com> wrote: > > > > On Tue, Jun 30, 2020 at 12:07:51PM -0500, Adam Ford wrote: > > > On Tue, Jun 30, 2020 at 11:56 AM Tom Rini <trini at konsulko.com> wrote: > > > > > > > > Disable USB support for now. There is non-trivial work required to > > > > fully move the OMAP3 platforms to DM. While this work is in-progress, > > > > disable USB support for now as we've gone well past the migration > > > > deadline. > > > > > > > > Cc: Adam Ford <aford173 at gmail.com> > > > > Signed-off-by: Tom Rini <trini at konsulko.com> > > > > --- > > > > > > I don't have a beagle, but I have DM_USB working on two different > > > OMAP3 boards. I am curious to know what's left or what's not working. > > > > Oh? I thought when we talked last there was still more to do to fully > > migrate things over. Where should I check again to see what I need to > > do on beagle to convert it over? Thanks! > > With [1], the DM support for the EHCI controller was added. There is > still some work to be done to make it better, because there are still > some #defines that need to assign the reset GPIO's. Ideally we'd get > rid of the GPIO defines and use the device tree to address the reset. > It isn't perfect, but it's better than having no USB at all. The > am3517_evm and omap3_logic_somlv have them working. Make sure the > board files have the legacy USB stuff removed [2] > > [1] - https://gitlab.denx.de/u-boot/u-boot/-/commit/94ed66194f150c308d1713965a28abce3ac6e200 > [2] - https://gitlab.denx.de/u-boot/u-boot/-/commit/76f6d52e61a1968702af69d6cea463b9d9332a96 > > Let me know if there is anything I can do to help. Hunh, thanks. I thought I had tried this much before but had things blow up. With [2] it's a quick conversion and passing basic sanity checks. Thanks!
On Tue, Jun 30, 2020 at 12:56:48PM -0400, Tom Rini wrote: > Disable USB support for now. There is non-trivial work required to > fully move the OMAP3 platforms to DM. While this work is in-progress, > disable USB support for now as we've gone well past the migration > deadline. > > Cc: Adam Ford <aford173 at gmail.com> > Signed-off-by: Tom Rini <trini at konsulko.com> As Adam noted, I should just convert this instead. It does in fact convert easily at this point, so I'm rejecting this patch and will post a conversion instead soon.
diff --git a/configs/omap3_beagle_defconfig b/configs/omap3_beagle_defconfig index ed7cb8f2ff63..236a4f4f5f5a 100644 --- a/configs/omap3_beagle_defconfig +++ b/configs/omap3_beagle_defconfig @@ -9,6 +9,7 @@ CONFIG_NR_DRAM_BANKS=2 CONFIG_SPL=y CONFIG_SPL_TEXT_BASE=0x40200000 CONFIG_DISTRO_DEFAULTS=y +CONFIG_ANDROID_BOOT_IMAGE=y CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd" CONFIG_USE_PREBOOT=y CONFIG_PREBOOT="usb start" @@ -31,7 +32,6 @@ CONFIG_CMD_MMC=y CONFIG_CMD_NAND=y CONFIG_CMD_NAND_TRIMFFS=y CONFIG_CMD_SPI=y -CONFIG_CMD_USB=y CONFIG_CMD_CACHE=y CONFIG_CMD_EXT4_WRITE=y CONFIG_CMD_FS_UUID=y @@ -50,8 +50,6 @@ CONFIG_ENV_IS_IN_NAND=y CONFIG_SPL_DM=y CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SPL_OF_TRANSLATE=y -CONFIG_USB_FUNCTION_FASTBOOT=y -CONFIG_FASTBOOT_BUF_ADDR=0x82000000 CONFIG_LED_STATUS=y CONFIG_LED_STATUS0=y CONFIG_LED_STATUS_BIT=1 @@ -73,24 +71,10 @@ CONFIG_SYS_NAND_BUSWIDTH_16BIT=y CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y CONFIG_SYS_NAND_U_BOOT_OFFS=0x80000 CONFIG_SPL_NAND_SIMPLE=y +CONFIG_DM_ETH=y CONFIG_SPI=y CONFIG_DM_SPI=y CONFIG_OMAP3_SPI=y -CONFIG_USB=y -CONFIG_USB_EHCI_HCD=y -CONFIG_USB_OMAP3=y -CONFIG_USB_MUSB_GADGET=y -CONFIG_USB_MUSB_OMAP2PLUS=y -CONFIG_TWL4030_USB=y -CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="TI" -CONFIG_USB_GADGET_VENDOR_NUM=0x0451 -CONFIG_USB_GADGET_PRODUCT_NUM=0xd022 -CONFIG_USB_ETHER=y -CONFIG_USB_HOST_ETHER=y -CONFIG_USB_ETHER_ASIX=y -CONFIG_USB_ETHER_MCS7830=y -CONFIG_USB_ETHER_SMSC95XX=y CONFIG_VIDEO_OMAP3=y CONFIG_FAT_WRITE=y CONFIG_BCH=y
Disable USB support for now. There is non-trivial work required to fully move the OMAP3 platforms to DM. While this work is in-progress, disable USB support for now as we've gone well past the migration deadline. Cc: Adam Ford <aford173 at gmail.com> Signed-off-by: Tom Rini <trini at konsulko.com> --- configs/omap3_beagle_defconfig | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-)