diff mbox series

[20/20] gitlab: Simplify the exit code for test.py

Message ID	20200307030734.237401-16-sjg@chromium.org
State	New
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: sjg at chromium.org (Simon Glass) Date: Fri, 6 Mar 2020 20:07:34 -0700 Subject: [PATCH 20/20] gitlab: Simplify the exit code for test.py In-Reply-To: <20200307030734.237401-1-sjg@chromium.org> References: <20200307030734.237401-1-sjg@chromium.org> Message-ID: <20200307030734.237401-16-sjg@chromium.org>
Series	gitlab: Simplify the test script \| expand [00/20] gitlab: Simplify the test script [01/20] sandbox: Add documentation about required/useful packages [02/20] main: Drop show_boot_progress() prototype [03/20] buildman: Document the members of BuilderJob [04/20] bulidman: Add support for a simple build [05/20] gitlab: Use the -w option for sandbox_spl [06/20] azure: Use the -w option for sandbox_spl [07/20] gitlab: Use the --board buildman flag [08/20] gitlab: Drop the BUILDMAN variable [09/20] buildman: Update help for -d [10/20] gitlab: Drop the buildman -d flag [11/20] gitlab: Drop unnecessary if..fi [12/20] gitlab: Use -w flag for all builds [13/20] gitlab: Use bash to avoid needing a_test_which_does_not_exist [14/20] buildman: Allow ignoring warnings in the return code [15/20] gitlab: Use the buildman -W flag [16/20] gitlab: Enable test_handoff [17/20] buildman: Be more selective about which directories to remove [18/20] buildman: Allow building within a subdir of the current dir [19/20] test/py: Use buildman to build U-Boot [20/20] gitlab: Simplify the exit code for test.py

Commit Message

Simon Glass March 7, 2020, 3:07 a.m. UTC

It seems unnecessary to read the exit code and then check it again. Drop
this and just let the test.py provide the exit code directly.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 .gitlab-ci.yml | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 26c8fb3199..98adfa7d80 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -39,11 +39,7 @@  stages:
       export PYTHONPATH=/tmp/uboot-test-hooks/py/travis-ci;
       ./test/py/test.py --bd ${TEST_PY_BD} ${TEST_PY_ID}
         ${TEST_PY_TEST_SPEC:+"-k ${TEST_PY_TEST_SPEC}"}
-        --build-dir "$UBOOT_TRAVIS_BUILD_DIR";
-      ret=$?;
-      if [[ $ret -ne 0 ]]; then
-        exit $ret;
-      fi
+        --build-dir "$UBOOT_TRAVIS_BUILD_DIR"
 
 build all 32bit ARM platforms:
   tags: [ 'all' ]