| Message ID | 20200326170727.35794-1-hws@denx.de |
|---|---|
| State | Accepted |
| Commit | 6748a1f2a3e59a867a55487916167c4a676a884e |
| Headers | show |
| Series | test/py: mmc: Fix 'mmc info' testcase | expand |
On 3/26/20 11:07 AM, Harald Seiler wrote: > Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed > the layout of `mmc info` output. Reflect this change in the respective > testcase. > > Also fix a typo in the documentation. Acked-by: Stephen Warren <swarren at nvidia.com> I guess I don't have these tests enabled, which is why my test system didn't catch this.
On Thu, 26 Mar 2020 at 11:08, Harald Seiler <hws at denx.de> wrote: > > Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed > the layout of `mmc info` output. Reflect this change in the respective > testcase. > > Also fix a typo in the documentation. > > Fixes: 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") > Signed-off-by: Harald Seiler <hws at denx.de> > --- > test/py/tests/test_mmc_rd.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg at chromium.org>
On Thu, Mar 26, 2020 at 06:07:27PM +0100, Harald Seiler wrote: > Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed > the layout of `mmc info` output. Reflect this change in the respective > testcase. > > Also fix a typo in the documentation. > > Fixes: 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") > Signed-off-by: Harald Seiler <hws at denx.de> > Acked-by: Stephen Warren <swarren at nvidia.com> > Reviewed-by: Simon Glass <sjg at chromium.org> Applied to u-boot/master, thanks!
diff --git a/test/py/tests/test_mmc_rd.py b/test/py/tests/test_mmc_rd.py index a25aa5f6f78e..ea652f913618 100644 --- a/test/py/tests/test_mmc_rd.py +++ b/test/py/tests/test_mmc_rd.py @@ -56,7 +56,7 @@ env__mmc_dev_configs = ( 'info_mode': ???, 'info_buswidth': ???. }, -} +) # Configuration data for test_mmc_rd; defines regions of the MMC (entire # devices, or ranges of sectors) which can be read: @@ -210,7 +210,7 @@ def test_mmc_info(u_boot_console, env__mmc_dev_config): assert good_response in response good_response = "Bus Speed: %s" % info_speed assert good_response in response - good_response = "Mode : %s" % info_mode + good_response = "Mode: %s" % info_mode assert good_response in response good_response = "Bus Width: %s" % info_buswidth assert good_response in response
Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed the layout of `mmc info` output. Reflect this change in the respective testcase. Also fix a typo in the documentation. Fixes: 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") Signed-off-by: Harald Seiler <hws at denx.de> --- test/py/tests/test_mmc_rd.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)