diff mbox series

[v3,6/7] ARM: dts: rk3399-evb: usb3.0 host support

Message ID 20200507081319.16218-1-frank.wang@rock-chips.com
State New
Headers show
Series Add Rockchip RK3399 USB3.0 Host support | expand

Commit Message

Frank Wang May 7, 2020, 8:13 a.m. UTC
Configure 'tcphy1' and 'usbdrd_dwc3_1' nodes to support USB3.0 host
for Rockchip RK3399 Evaluation Board.

Signed-off-by: Frank Wang <frank.wang at rock-chips.com>
---
Changes for v3:
- drop dtsi changes to keep the same with Linux Kernel.
- amend rk3399-evb.dts to support usb3.0 host.

 arch/arm/dts/rk3399-evb.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Peter Robinson May 7, 2020, 8:17 a.m. UTC | #1
On Thu, May 7, 2020 at 9:13 AM Frank Wang <frank.wang at rock-chips.com> wrote:
>
> Configure 'tcphy1' and 'usbdrd_dwc3_1' nodes to support USB3.0 host
> for Rockchip RK3399 Evaluation Board.
>
> Signed-off-by: Frank Wang <frank.wang at rock-chips.com>
> ---
> Changes for v3:
> - drop dtsi changes to keep the same with Linux Kernel.
> - amend rk3399-evb.dts to support usb3.0 host.

If this is specific to U-Boot it should go in
arch/arm/dts/rk3399-evb-u-boot.dtsi as the rk3399-evb.dts is intended
to be the same as what's in Linux.

>  arch/arm/dts/rk3399-evb.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts
> index 694b0d08d6..5aa46f4e37 100644
> --- a/arch/arm/dts/rk3399-evb.dts
> +++ b/arch/arm/dts/rk3399-evb.dts
> @@ -417,6 +417,10 @@
>         status = "disabled";
>  };
>
> +&tcphy1 {
> +       status = "okay";
> +};
> +
>  &u2phy0 {
>         status = "okay";
>  };
> @@ -439,6 +443,15 @@
>         status = "okay";
>  };
>
> +&usbdrd3_1 {
> +       status = "okay";
> +};
> +
> +&usbdrd_dwc3_1 {
> +       dr_mode = "host";
> +       status = "okay";
> +};
> +
>  &usb_host0_ehci {
>         status = "okay";
>  };
> --
> 2.17.1
>
>
>
Frank Wang May 8, 2020, 12:13 a.m. UTC | #2
Hi Peter,

On 2020/5/7 16:17, Peter Robinson wrote:
> On Thu, May 7, 2020 at 9:13 AM Frank Wang <frank.wang at rock-chips.com> wrote:
>> Configure 'tcphy1' and 'usbdrd_dwc3_1' nodes to support USB3.0 host
>> for Rockchip RK3399 Evaluation Board.
>>
>> Signed-off-by: Frank Wang <frank.wang at rock-chips.com>
>> ---
>> Changes for v3:
>> - drop dtsi changes to keep the same with Linux Kernel.
>> - amend rk3399-evb.dts to support usb3.0 host.
> If this is specific to U-Boot it should go in
> arch/arm/dts/rk3399-evb-u-boot.dtsi as the rk3399-evb.dts is intended
> to be the same as what's in Linux.

Will fix.

>>   arch/arm/dts/rk3399-evb.dts | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts
>> index 694b0d08d6..5aa46f4e37 100644
>> --- a/arch/arm/dts/rk3399-evb.dts
>> +++ b/arch/arm/dts/rk3399-evb.dts
>> @@ -417,6 +417,10 @@
>>          status = "disabled";
>>   };
>>
>> +&tcphy1 {
>> +       status = "okay";
>> +};
>> +
>>   &u2phy0 {
>>          status = "okay";
>>   };
>> @@ -439,6 +443,15 @@
>>          status = "okay";
>>   };
>>
>> +&usbdrd3_1 {
>> +       status = "okay";
>> +};
>> +
>> +&usbdrd_dwc3_1 {
>> +       dr_mode = "host";
>> +       status = "okay";
>> +};
>> +
>>   &usb_host0_ehci {
>>          status = "okay";
>>   };
>> --
>> 2.17.1
>>
>>
>>
>
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts
index 694b0d08d6..5aa46f4e37 100644
--- a/arch/arm/dts/rk3399-evb.dts
+++ b/arch/arm/dts/rk3399-evb.dts
@@ -417,6 +417,10 @@ 
 	status = "disabled";
 };
 
+&tcphy1 {
+	status = "okay";
+};
+
 &u2phy0 {
 	status = "okay";
 };
@@ -439,6 +443,15 @@ 
 	status = "okay";
 };
 
+&usbdrd3_1 {
+	status = "okay";
+};
+
+&usbdrd_dwc3_1 {
+	dr_mode = "host";
+	status = "okay";
+};
+
 &usb_host0_ehci {
 	status = "okay";
 };