diff mbox series

x86: mtrr: Drop the mask display when changing an mtrr

Message ID 20200507141252.109723-1-sjg@chromium.org
State Accepted
Commit b032db2725dcd440811465f674e93f6c3a0a2573
Headers show
Series x86: mtrr: Drop the mask display when changing an mtrr | expand

Commit Message

Simon Glass May 7, 2020, 2:12 p.m. UTC
We don't need to print this information since it is shown when the MTRRs
are displayed. Drop it.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 cmd/x86/mtrr.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bin Meng May 7, 2020, 2:32 p.m. UTC | #1
On Thu, May 7, 2020 at 10:13 PM Simon Glass <sjg at chromium.org> wrote:
>
> We don't need to print this information since it is shown when the MTRRs
> are displayed. Drop it.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  cmd/x86/mtrr.c | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Bin Meng May 17, 2020, 1:54 p.m. UTC | #2
On Thu, May 7, 2020 at 10:32 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Thu, May 7, 2020 at 10:13 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > We don't need to print this information since it is shown when the MTRRs
> > are displayed. Drop it.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  cmd/x86/mtrr.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/cmd/x86/mtrr.c b/cmd/x86/mtrr.c
index d3fd959235..ac36a40854 100644
--- a/cmd/x86/mtrr.c
+++ b/cmd/x86/mtrr.c
@@ -72,7 +72,6 @@  static int do_mtrr_set(uint reg, int argc, char * const argv[])
 	if (valid)
 		mask |= MTRR_PHYS_MASK_VALID;
 
-	printf("base=%llx, mask=%llx\n", base, mask);
 	mtrr_open(&state, true);
 	wrmsrl(MTRR_PHYS_BASE_MSR(reg), base);
 	wrmsrl(MTRR_PHYS_MASK_MSR(reg), mask);