diff mbox series

cbfs: drop file_cbfs_result declaration

Message ID 20200519090159.64752-1-christian.gmeiner@gmail.com
State Accepted
Commit 30cf2ba7c6794c7b486c34aba2b25af66609bc42
Headers show
Series cbfs: drop file_cbfs_result declaration | expand

Commit Message

Christian Gmeiner May 19, 2020, 9:01 a.m. UTC
It is not definded anywhere.

Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
---
 include/cbfs.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Heinrich Schuchardt May 19, 2020, 10:30 a.m. UTC | #1
On 19.05.20 11:01, Christian Gmeiner wrote:
> It is not definded anywhere.
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>

git grep -n 'file_cbfs_result'
finds only the line in the include.

Reviewed-by: Heinrich Schuchardt <xypron.gpk at gmx.de>

> ---
>  include/cbfs.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/cbfs.h b/include/cbfs.h
> index d915f9426d..d18001da76 100644
> --- a/include/cbfs.h
> +++ b/include/cbfs.h
> @@ -80,8 +80,6 @@ struct cbfs_cachenode {
>  	u32 attributes_offset;
>  };
>
> -extern enum cbfs_result file_cbfs_result;
> -
>  /**
>   * file_cbfs_error() - Return a string describing the most recent error
>   * condition.
>
Bin Meng May 19, 2020, 1:37 p.m. UTC | #2
On Tue, May 19, 2020 at 5:02 PM Christian Gmeiner
<christian.gmeiner at gmail.com> wrote:
>
> It is not definded anywhere.
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> ---
>  include/cbfs.h | 2 --
>  1 file changed, 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Bin Meng May 19, 2020, 2:17 p.m. UTC | #3
On Tue, May 19, 2020 at 9:37 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Tue, May 19, 2020 at 5:02 PM Christian Gmeiner
> <christian.gmeiner at gmail.com> wrote:
> >
> > It is not definded anywhere.
> >
> > Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> > ---
> >  include/cbfs.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/include/cbfs.h b/include/cbfs.h
index d915f9426d..d18001da76 100644
--- a/include/cbfs.h
+++ b/include/cbfs.h
@@ -80,8 +80,6 @@  struct cbfs_cachenode {
 	u32 attributes_offset;
 };
 
-extern enum cbfs_result file_cbfs_result;
-
 /**
  * file_cbfs_error() - Return a string describing the most recent error
  * condition.