tbs2910: migrate to DM_VIDEO

Migration to DM_VIDEO driver is long overdue, configure it in
board config files. To enable the display set stdout like:

  setenv stdout serial,vidconsole

Signed-off-by: Anatolij Gustschin <agust at denx.de>
---
This is only build tested.

 configs/tbs2910_defconfig | 7 ++++++-
 include/configs/tbs2910.h | 2 --
 2 files changed, 6 insertions(+), 3 deletions(-)

On 23.05.20 01:24, Anatolij Gustschin wrote:
> Migration to DM_VIDEO driver is long overdue, configure it in
> board config files. To enable the display set stdout like:
>
>   setenv stdout serial,vidconsole
And this exactly is the problem.
There are some users of this board without serial console. They have no
chance to set this after upgrading u-boot.

What is the reason behind this incompatible change? In other words, why
vga cannot be an alias for vidconsole, if this is the preferred name
nowadays?

Regards,
Soeren
>
> Signed-off-by: Anatolij Gustschin <agust at denx.de>
> ---
> This is only build tested.
>
>  configs/tbs2910_defconfig | 7 ++++++-
>  include/configs/tbs2910.h | 2 --
>  2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig
> index 2ff0e160f7..b40641c17b 100644
> --- a/configs/tbs2910_defconfig
> +++ b/configs/tbs2910_defconfig
> @@ -1,6 +1,7 @@
>  CONFIG_ARM=y
>  CONFIG_ARCH_MX6=y
>  CONFIG_SYS_TEXT_BASE=0x17800000
> +CONFIG_SYS_MALLOC_F_LEN=0x4000
>  CONFIG_ENV_SIZE=0x2000
>  CONFIG_ENV_OFFSET=0x60000
>  CONFIG_TARGET_TBS2910=y
> @@ -84,7 +85,11 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
>  CONFIG_CI_UDC=y
>  CONFIG_USB_GADGET_DOWNLOAD=y
>  CONFIG_I2C_EDID=y
> +CONFIG_DM_VIDEO=y
> +# CONFIG_VIDEO_BPP8 is not set
> +# CONFIG_VIDEO_BPP32 is not set
> +# CONFIG_VIDEO_ANSI is not set
>  CONFIG_VIDEO_IPUV3=y
> -CONFIG_VIDEO=y
> +CONFIG_SYS_WHITE_ON_BLACK=y
>  CONFIG_OF_LIBFDT_ASSUME_MASK=0xff
>  # CONFIG_EFI_LOADER is not set
> diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h
> index 7376b91f55..8ab3fcfe3e 100644
> --- a/include/configs/tbs2910.h
> +++ b/include/configs/tbs2910.h
> @@ -37,11 +37,9 @@
>  #define CONFIG_MXC_UART_BASE		UART1_BASE /* select UART1/UART2 */
>
>  /* Framebuffer */
> -#ifdef CONFIG_VIDEO
>  #define CONFIG_VIDEO_BMP_RLE8
>  #define CONFIG_IMX_HDMI
>  #define CONFIG_IMX_VIDEO_SKIP
> -#endif
>
>  /* PCI */
>  #ifdef CONFIG_CMD_PCI

On Sat, 23 May 2020 09:55:48 +0200
Soeren Moch smoch at web.de wrote:

> On 23.05.20 01:24, Anatolij Gustschin wrote:
> > Migration to DM_VIDEO driver is long overdue, configure it in
> > board config files. To enable the display set stdout like:
> >
> >   setenv stdout serial,vidconsole  
> And this exactly is the problem.
> There are some users of this board without serial console. They have no
> chance to set this after upgrading u-boot.
> 
> What is the reason behind this incompatible change? In other words, why
> vga cannot be an alias for vidconsole, if this is the preferred name
> nowadays?

DM video console driver uses more generic name for the video console.
As a work-around, an alias exists for 'lcd' name. I've sent a patch
to also use 'vga' as an alias.

--
Anatolij

On 23.05.20 17:17, Anatolij Gustschin wrote:
> On Sat, 23 May 2020 09:55:48 +0200
> Soeren Moch smoch at web.de wrote:
>
>> On 23.05.20 01:24, Anatolij Gustschin wrote:
>>> Migration to DM_VIDEO driver is long overdue, configure it in
>>> board config files. To enable the display set stdout like:
>>>
>>>   setenv stdout serial,vidconsole
>> And this exactly is the problem.
>> There are some users of this board without serial console. They have no
>> chance to set this after upgrading u-boot.
>>
>> What is the reason behind this incompatible change? In other words, why
>> vga cannot be an alias for vidconsole, if this is the preferred name
>> nowadays?
> DM video console driver uses more generic name for the video console.
> As a work-around, an alias exists for 'lcd' name. I've sent a patch
> to also use 'vga' as an alias.
>
Thanks.

I will test both patches for tbs2910.

Soeren