diff mbox series

spi-nor: Remove unused spi-nor.o rule

Message ID 20200722084241.193470-1-joel@jms.id.au
State New
Headers show
Series spi-nor: Remove unused spi-nor.o rule | expand

Commit Message

Joel Stanley July 22, 2020, 8:42 a.m. UTC 
In "mtd: spi-nor: Prepare core / manufacturer code split" the file was
refactored into seperate files, so the rule is no longer required.

Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
Reported-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 drivers/mtd/spi-nor/Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Joel Stanley July 22, 2020, 9:31 a.m. UTC | #1 
On Wed, 22 Jul 2020 at 09:00, Joel Stanley <joel@jms.id.au> wrote:
>
> In "mtd: spi-nor: Prepare core / manufacturer code split" the file was
> refactored into seperate files, so the rule is no longer required.

Please ignore this patch. I misunderstood how spi-nor-objs worked, and
didn't properly test the patch.

I am still a bit confused as to how spi-nor.o gets linked in, as
there's no spi-nor.o on my filesystem. Can someone explain how it
works?

> Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
> Reported-by: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  drivers/mtd/spi-nor/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
> index 653923896205..2ede5ef79b01 100644
> --- a/drivers/mtd/spi-nor/Makefile
> +++ b/drivers/mtd/spi-nor/Makefile
> @@ -17,6 +17,5 @@ spi-nor-objs                  += sst.o
>  spi-nor-objs                   += winbond.o
>  spi-nor-objs                   += xilinx.o
>  spi-nor-objs                   += xmc.o
> -obj-$(CONFIG_MTD_SPI_NOR)      += spi-nor.o
>
>  obj-$(CONFIG_MTD_SPI_NOR)      += controllers/
> --
> 2.27.0
>
kernel test robot July 26, 2020, 11:51 a.m. UTC | #2 
Hi Joel,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc6 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Joel-Stanley/spi-nor-Remove-unused-spi-nor-o-rule/20200722-170150
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4fa640dc52302b5e62b01b05c755b055549633ae
config: i386-randconfig-c001-20200726 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/mtd/spi-nor/controllers/intel-spi.o: in function `intel_spi_probe':
>> drivers/mtd/spi-nor/controllers/intel-spi.c:932: undefined reference to `spi_nor_scan'


vim +932 drivers/mtd/spi-nor/controllers/intel-spi.c

45397787536434 drivers/mtd/spi-nor/intel-spi.c Tudor Ambarus     2019-09-24  896  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  897  struct intel_spi *intel_spi_probe(struct device *dev,
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  898  	struct resource *mem, const struct intel_spi_boardinfo *info)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  899  {
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen   2017-04-25  900  	const struct spi_nor_hwcaps hwcaps = {
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen   2017-04-25  901  		.mask = SNOR_HWCAPS_READ |
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen   2017-04-25  902  			SNOR_HWCAPS_READ_FAST |
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen   2017-04-25  903  			SNOR_HWCAPS_PP,
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen   2017-04-25  904  	};
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  905  	struct mtd_partition part;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  906  	struct intel_spi *ispi;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  907  	int ret;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  908  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  909  	if (!info || !mem)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  910  		return ERR_PTR(-EINVAL);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  911  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  912  	ispi = devm_kzalloc(dev, sizeof(*ispi), GFP_KERNEL);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  913  	if (!ispi)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  914  		return ERR_PTR(-ENOMEM);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  915  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  916  	ispi->base = devm_ioremap_resource(dev, mem);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  917  	if (IS_ERR(ispi->base))
011de1b1db534b drivers/mtd/spi-nor/intel-spi.c Nicholas Mc Guire 2017-02-13  918  		return ERR_CAST(ispi->base);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  919  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  920  	ispi->dev = dev;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  921  	ispi->info = info;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  922  	ispi->writeable = info->writeable;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  923  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  924  	ret = intel_spi_init(ispi);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  925  	if (ret)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  926  		return ERR_PTR(ret);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  927  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  928  	ispi->nor.dev = ispi->dev;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  929  	ispi->nor.priv = ispi;
45397787536434 drivers/mtd/spi-nor/intel-spi.c Tudor Ambarus     2019-09-24  930  	ispi->nor.controller_ops = &intel_spi_controller_ops;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  931  
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen   2017-04-25 @932  	ret = spi_nor_scan(&ispi->nor, NULL, &hwcaps);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  933  	if (ret) {
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  934  		dev_info(dev, "failed to locate the chip\n");
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  935  		return ERR_PTR(ret);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  936  	}
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  937  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  938  	intel_spi_fill_partition(ispi, &part);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  939  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  940  	/* Prevent writes if not explicitly enabled */
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  941  	if (!ispi->writeable || !writeable)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  942  		ispi->nor.mtd.flags &= ~MTD_WRITEABLE;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  943  
11edc1133e3023 drivers/mtd/spi-nor/intel-spi.c Rafał Miłecki     2018-07-21  944  	ret = mtd_device_register(&ispi->nor.mtd, &part, 1);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  945  	if (ret)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  946  		return ERR_PTR(ret);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  947  
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  948  	return ispi;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  949  }
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  950  EXPORT_SYMBOL_GPL(intel_spi_probe);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg   2016-11-28  951  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
kernel test robot July 26, 2020, 12:16 p.m. UTC | #3 
Hi Joel,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc6 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Joel-Stanley/spi-nor-Remove-unused-spi-nor-o-rule/20200722-170150
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4fa640dc52302b5e62b01b05c755b055549633ae
config: arm-randconfig-r036-20200726 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: drivers/mtd/spi-nor/controllers/aspeed-smc.o: in function `aspeed_smc_setup_flash':
>> drivers/mtd/spi-nor/controllers/aspeed-smc.c:829: undefined reference to `spi_nor_scan'


vim +829 drivers/mtd/spi-nor/controllers/aspeed-smc.c

45397787536434 drivers/mtd/spi-nor/aspeed-smc.c Tudor Ambarus    2019-09-24  758  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  759  static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller,
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  760  				  struct device_node *np, struct resource *r)
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  761  {
cfc5604c488ccd drivers/mtd/spi-nor/aspeed-smc.c Cyrille Pitchen  2017-04-25  762  	const struct spi_nor_hwcaps hwcaps = {
cfc5604c488ccd drivers/mtd/spi-nor/aspeed-smc.c Cyrille Pitchen  2017-04-25  763  		.mask = SNOR_HWCAPS_READ |
cfc5604c488ccd drivers/mtd/spi-nor/aspeed-smc.c Cyrille Pitchen  2017-04-25  764  			SNOR_HWCAPS_READ_FAST |
cfc5604c488ccd drivers/mtd/spi-nor/aspeed-smc.c Cyrille Pitchen  2017-04-25  765  			SNOR_HWCAPS_PP,
cfc5604c488ccd drivers/mtd/spi-nor/aspeed-smc.c Cyrille Pitchen  2017-04-25  766  	};
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  767  	const struct aspeed_smc_info *info = controller->info;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  768  	struct device *dev = controller->dev;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  769  	struct device_node *child;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  770  	unsigned int cs;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  771  	int ret = -ENODEV;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  772  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  773  	for_each_available_child_of_node(np, child) {
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  774  		struct aspeed_smc_chip *chip;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  775  		struct spi_nor *nor;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  776  		struct mtd_info *mtd;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  777  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  778  		/* This driver does not support NAND or NOR flash devices. */
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  779  		if (!of_device_is_compatible(child, "jedec,spi-nor"))
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  780  			continue;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  781  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  782  		ret = of_property_read_u32(child, "reg", &cs);
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  783  		if (ret) {
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  784  			dev_err(dev, "Couldn't not read chip select.\n");
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  785  			break;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  786  		}
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  787  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  788  		if (cs >= info->nce) {
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  789  			dev_err(dev, "Chip select %d out of range.\n",
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  790  				cs);
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  791  			ret = -ERANGE;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  792  			break;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  793  		}
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  794  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  795  		if (controller->chips[cs]) {
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  796  			dev_err(dev, "Chip select %d already in use by %s\n",
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  797  				cs, dev_name(controller->chips[cs]->nor.dev));
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  798  			ret = -EBUSY;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  799  			break;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  800  		}
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  801  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  802  		chip = devm_kzalloc(controller->dev, sizeof(*chip), GFP_KERNEL);
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  803  		if (!chip) {
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  804  			ret = -ENOMEM;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  805  			break;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  806  		}
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  807  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  808  		chip->controller = controller;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  809  		chip->ctl = controller->regs + info->ctl0 + cs * 4;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  810  		chip->cs = cs;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  811  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  812  		nor = &chip->nor;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  813  		mtd = &nor->mtd;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  814  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  815  		nor->dev = dev;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  816  		nor->priv = chip;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  817  		spi_nor_set_flash_node(nor, child);
45397787536434 drivers/mtd/spi-nor/aspeed-smc.c Tudor Ambarus    2019-09-24  818  		nor->controller_ops = &aspeed_smc_controller_ops;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  819  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  820  		ret = aspeed_smc_chip_setup_init(chip, r);
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  821  		if (ret)
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  822  			break;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  823  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  824  		/*
cfc5604c488ccd drivers/mtd/spi-nor/aspeed-smc.c Cyrille Pitchen  2017-04-25  825  		 * TODO: Add support for Dual and Quad SPI protocols
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  826  		 * attach when board support is present as determined
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  827  		 * by of property.
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  828  		 */
cfc5604c488ccd drivers/mtd/spi-nor/aspeed-smc.c Cyrille Pitchen  2017-04-25 @829  		ret = spi_nor_scan(nor, NULL, &hwcaps);
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  830  		if (ret)
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  831  			break;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  832  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  833  		ret = aspeed_smc_chip_setup_finish(chip);
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  834  		if (ret)
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  835  			break;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  836  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  837  		ret = mtd_device_register(mtd, NULL, 0);
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  838  		if (ret)
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  839  			break;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  840  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  841  		controller->chips[cs] = chip;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  842  	}
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  843  
6597f0b0516ab0 drivers/mtd/spi-nor/aspeed-smc.c Nishka Dasgupta  2019-08-08  844  	if (ret) {
6597f0b0516ab0 drivers/mtd/spi-nor/aspeed-smc.c Nishka Dasgupta  2019-08-08  845  		of_node_put(child);
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  846  		aspeed_smc_unregister(controller);
6597f0b0516ab0 drivers/mtd/spi-nor/aspeed-smc.c Nishka Dasgupta  2019-08-08  847  	}
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  848  
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  849  	return ret;
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  850  }
ceb720c71b6309 drivers/mtd/spi-nor/aspeed-smc.c Cédric Le Goater 2016-12-21  851  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
diff mbox series

Patch

diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
index 653923896205..2ede5ef79b01 100644
--- a/drivers/mtd/spi-nor/Makefile
+++ b/drivers/mtd/spi-nor/Makefile
@@ -17,6 +17,5 @@  spi-nor-objs			+= sst.o
 spi-nor-objs			+= winbond.o
 spi-nor-objs			+= xilinx.o
 spi-nor-objs			+= xmc.o
-obj-$(CONFIG_MTD_SPI_NOR)	+= spi-nor.o
 
 obj-$(CONFIG_MTD_SPI_NOR)	+= controllers/