drm: bridge: adv7511: Add missing bridge type

Message ID 20200723104523.1006706-1-vkoul@kernel.org
State New
Headers show
Series
  • drm: bridge: adv7511: Add missing bridge type
Related show

Commit Message

Vinod Koul July 23, 2020, 10:45 a.m.
Add bridge type as DRM_MODE_CONNECTOR_HDMIA

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---

I found this when testing Dragon-board 410c which uses this bridge
[    6.671913] msm 1a00000.mdss: [drm:msm_dsi_manager_ext_bridge_init [msm]] *ERROR* drm_bridge_connector_init failed: -22
[    6.678879] msm 1a00000.mdss: [drm:msm_dsi_modeset_init [msm]] *ERROR* failed to create dsi connector: -19

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.26.2

Comments

Laurent Pinchart July 24, 2020, 1:30 a.m. | #1
Hi Vinod,

Thank you for the patch.

On Thu, Jul 23, 2020 at 04:15:23PM +0530, Vinod Koul wrote:
> Add bridge type as DRM_MODE_CONNECTOR_HDMIA

> 

> Signed-off-by: Vinod Koul <vkoul@kernel.org>


This has already been submitted: https://lore.kernel.org/dri-devel/20200720124228.12552-1-laurentiu.palcu@oss.nxp.com/

> ---

> 

> I found this when testing Dragon-board 410c which uses this bridge

> [    6.671913] msm 1a00000.mdss: [drm:msm_dsi_manager_ext_bridge_init [msm]] *ERROR* drm_bridge_connector_init failed: -22

> [    6.678879] msm 1a00000.mdss: [drm:msm_dsi_modeset_init [msm]] *ERROR* failed to create dsi connector: -19

> 

>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

> index f45cdca9cce5..a0d392c338da 100644

> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

> @@ -1283,6 +1283,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)

>  	adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID

>  			    | DRM_BRIDGE_OP_HPD;

>  	adv7511->bridge.of_node = dev->of_node;

> +	adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;

>  

>  	drm_bridge_add(&adv7511->bridge);

>  


-- 
Regards,

Laurent Pinchart
Vinod Koul July 24, 2020, 4:23 a.m. | #2
On 24-07-20, 04:30, Laurent Pinchart wrote:
> Hi Vinod,

> 

> Thank you for the patch.

> 

> On Thu, Jul 23, 2020 at 04:15:23PM +0530, Vinod Koul wrote:

> > Add bridge type as DRM_MODE_CONNECTOR_HDMIA

> > 

> > Signed-off-by: Vinod Koul <vkoul@kernel.org>

> 

> This has already been submitted: https://lore.kernel.org/dri-devel/20200720124228.12552-1-laurentiu.palcu@oss.nxp.com/


OKay lets drop this one then

-- 
~Vinod

Patch

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f45cdca9cce5..a0d392c338da 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1283,6 +1283,7 @@  static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
 	adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
 			    | DRM_BRIDGE_OP_HPD;
 	adv7511->bridge.of_node = dev->of_node;
+	adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
 
 	drm_bridge_add(&adv7511->bridge);