| Message ID | 1392639281-2753-2-git-send-email-carl.wallen@linaro.org |
|---|---|
| State | Accepted, archived |
| Commit | 4c6e232ced29d461e5ec9744502dbd4aaddd7b7d |
| Headers | show |
On 2014-02-17 14:14, Carl Wallen wrote: > Signed-off-by: Carl Wallen <carl.wallen@linaro.org> > --- > include/helper/odp_eth.h | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/include/helper/odp_eth.h b/include/helper/odp_eth.h > index 834814f..d1cb33b 100644 > --- a/include/helper/odp_eth.h > +++ b/include/helper/odp_eth.h > @@ -23,10 +23,13 @@ extern "C" { > #include <odp_align.h> > #include <odp_debug.h> > > -#define ODP_ETHADDR_LEN 6 > -#define ODP_ETHHDR_LEN 14 > -#define ODP_VLANHDR_LEN 4 > -#define ODP_ETH_LEN_MIN 64 /* incl 4B CRC/FCS */ > +#define ODP_ETHADDR_LEN 6 > +#define ODP_ETHHDR_LEN 14 > +#define ODP_VLANHDR_LEN 4 > +#define ODP_ETH_LEN_MIN 60 /* exclude 4B CRC/FCS */ > +#define ODP_ETH_LEN_MIN_CRC 64 /* include 4B CRC/FCS */ > +#define ODP_ETH_LEN_MAX 1514 /* exclude 4B CRC/FCS */ > +#define ODP_ETH_LEN_MAX_CRC 1518 /* include 4B CRC/FCS */ Do we want the numbers right aligned (as you done it in patch: [lng-odp] [PATCH 2/7] ODP helper: Add IPv6 header and defines. Add & rename IPv4 defines or do we want it as in this patch left aligned? Cheers, Anders > > /** > * Ethernet MAC address > -- > 1.8.5.3 > > -- > You received this message because you are subscribed to the Google Groups "LNG ODP Sub-team - lng-odp@linaro.org" group. > To unsubscribe from this group and stop receiving emails from it, send an email to lng-odp+unsubscribe@linaro.org. > To post to this group, send email to lng-odp@linaro.org. > Visit this group at http://groups.google.com/a/linaro.org/group/lng-odp/. > To view this discussion on the web visit https://groups.google.com/a/linaro.org/d/msgid/lng-odp/1392639281-2753-2-git-send-email-carl.wallen%40linaro.org. > For more options, visit https://groups.google.com/a/linaro.org/groups/opt_out.
If we care enough, I think 'astyle' or a replacement should perform the correct formatting, I don't think we should be very strict unless it is trivial to be in compliance. Our current rule of pass checkpatch would allow either I think, so we may be straying into personal preference by being so detailed. On 17 February 2014 13:54, Anders Roxell <anders.roxell@linaro.org> wrote: > On 2014-02-17 14:14, Carl Wallen wrote: > > Signed-off-by: Carl Wallen <carl.wallen@linaro.org> > > --- > > include/helper/odp_eth.h | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/include/helper/odp_eth.h b/include/helper/odp_eth.h > > index 834814f..d1cb33b 100644 > > --- a/include/helper/odp_eth.h > > +++ b/include/helper/odp_eth.h > > @@ -23,10 +23,13 @@ extern "C" { > > #include <odp_align.h> > > #include <odp_debug.h> > > > > -#define ODP_ETHADDR_LEN 6 > > -#define ODP_ETHHDR_LEN 14 > > -#define ODP_VLANHDR_LEN 4 > > -#define ODP_ETH_LEN_MIN 64 /* incl 4B CRC/FCS */ > > +#define ODP_ETHADDR_LEN 6 > > +#define ODP_ETHHDR_LEN 14 > > +#define ODP_VLANHDR_LEN 4 > > +#define ODP_ETH_LEN_MIN 60 /* exclude 4B CRC/FCS */ > > +#define ODP_ETH_LEN_MIN_CRC 64 /* include 4B CRC/FCS */ > > +#define ODP_ETH_LEN_MAX 1514 /* exclude 4B CRC/FCS */ > > +#define ODP_ETH_LEN_MAX_CRC 1518 /* include 4B CRC/FCS */ > > Do we want the numbers right aligned (as you done it in patch: > [lng-odp] [PATCH 2/7] ODP helper: Add IPv6 header and defines. Add & > rename IPv4 defines > > or do we want it as in this patch left aligned? > > > Cheers, > Anders > > > > > /** > > * Ethernet MAC address > > -- > > 1.8.5.3 > > > > -- > > You received this message because you are subscribed to the Google > Groups "LNG ODP Sub-team - lng-odp@linaro.org" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to lng-odp+unsubscribe@linaro.org. > > To post to this group, send email to lng-odp@linaro.org. > > Visit this group at http://groups.google.com/a/linaro.org/group/lng-odp/ > . > > To view this discussion on the web visit > https://groups.google.com/a/linaro.org/d/msgid/lng-odp/1392639281-2753-2-git-send-email-carl.wallen%40linaro.org > . > > For more options, visit > https://groups.google.com/a/linaro.org/groups/opt_out. > > -- > Anders Roxell > anders.roxell@linaro.org > M: +46 709 71 42 85 | IRC: roxell > > -- > You received this message because you are subscribed to the Google Groups > "LNG ODP Sub-team - lng-odp@linaro.org" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to lng-odp+unsubscribe@linaro.org. > To post to this group, send email to lng-odp@linaro.org. > Visit this group at http://groups.google.com/a/linaro.org/group/lng-odp/. > To view this discussion on the web visit > https://groups.google.com/a/linaro.org/d/msgid/lng-odp/20140217185441.GB25915%408470w > . > For more options, visit > https://groups.google.com/a/linaro.org/groups/opt_out. >
diff --git a/include/helper/odp_eth.h b/include/helper/odp_eth.h index 834814f..d1cb33b 100644 --- a/include/helper/odp_eth.h +++ b/include/helper/odp_eth.h @@ -23,10 +23,13 @@ extern "C" { #include <odp_align.h> #include <odp_debug.h> -#define ODP_ETHADDR_LEN 6 -#define ODP_ETHHDR_LEN 14 -#define ODP_VLANHDR_LEN 4 -#define ODP_ETH_LEN_MIN 64 /* incl 4B CRC/FCS */ +#define ODP_ETHADDR_LEN 6 +#define ODP_ETHHDR_LEN 14 +#define ODP_VLANHDR_LEN 4 +#define ODP_ETH_LEN_MIN 60 /* exclude 4B CRC/FCS */ +#define ODP_ETH_LEN_MIN_CRC 64 /* include 4B CRC/FCS */ +#define ODP_ETH_LEN_MAX 1514 /* exclude 4B CRC/FCS */ +#define ODP_ETH_LEN_MAX_CRC 1518 /* include 4B CRC/FCS */ /** * Ethernet MAC address
Signed-off-by: Carl Wallen <carl.wallen@linaro.org> --- include/helper/odp_eth.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)