From patchwork Mon Feb 17 15:21:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 24778 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CAE6420468 for ; Mon, 17 Feb 2014 15:21:09 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id v10sf34465886pde.9 for ; Mon, 17 Feb 2014 07:21:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=7WIln+WbmmutvH7CJ28I9qInTC+97CHcRMXgOetZP8E=; b=ePkhfFrdCDVi/VOy9RFR+fYSglzhOSxseZIfC/eKXLL9DW1kvCDJJwMJ/q34ub7msn sKbkgSfzPgv76fvFPiavGrwD6i3srT4ubwuG9usw85BrfjJJpbUMPA8xywnYLOB25bMF iX/baaCs2DVs7IpERLbyiHb+C90bq83W1/Tp0TeqOiaSH9Q/hdbK3Ecz7Ik0QOZ5Lcdf LHR0oYaWKlcHKfGTfLWclOMrKngnebU+CKrb5MPyoCKYuDWEJ+Ea6vbdZ0svWPW1zcfR MPH5Xk04KTiNNT8xUvuNUyj328A3j8JU5rKjG5pznj3Am1cAtsUJYx37jUuL19dizmha Mb+w== X-Gm-Message-State: ALoCoQm8HL4bomeP/pva4zaFJUyvWCh3uIlP78pOkXEyc5Xfy+xFzRmu4B05oq74nylqK5IuxScR X-Received: by 10.66.142.131 with SMTP id rw3mr10564267pab.18.1392650469037; Mon, 17 Feb 2014 07:21:09 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.86.212 with SMTP id p78ls963577qgd.10.gmail; Mon, 17 Feb 2014 07:21:08 -0800 (PST) X-Received: by 10.52.229.133 with SMTP id sq5mr1401751vdc.45.1392650468909; Mon, 17 Feb 2014 07:21:08 -0800 (PST) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id fi9si4531896vcb.114.2014.02.17.07.21.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Feb 2014 07:21:08 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id ik5so12140655vcb.9 for ; Mon, 17 Feb 2014 07:21:08 -0800 (PST) X-Received: by 10.52.106.166 with SMTP id gv6mr18941vdb.86.1392650468828; Mon, 17 Feb 2014 07:21:08 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp146497vcz; Mon, 17 Feb 2014 07:21:08 -0800 (PST) X-Received: by 10.112.56.237 with SMTP id d13mr17284847lbq.2.1392650467882; Mon, 17 Feb 2014 07:21:07 -0800 (PST) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com [209.85.217.180]) by mx.google.com with ESMTPS id e6si25683097lam.9.2014.02.17.07.21.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Feb 2014 07:21:07 -0800 (PST) Received-SPF: neutral (google.com: 209.85.217.180 is neither permitted nor denied by best guess record for domain of ulf.hansson@linaro.org) client-ip=209.85.217.180; Received: by mail-lb0-f180.google.com with SMTP id n15so11488236lbi.11 for ; Mon, 17 Feb 2014 07:21:07 -0800 (PST) X-Received: by 10.112.148.104 with SMTP id tr8mr1662056lbb.62.1392650467036; Mon, 17 Feb 2014 07:21:07 -0800 (PST) Received: from linaro-ulf.lan (90-231-160-185-no158.tbcn.telia.com. [90.231.160.185]) by mx.google.com with ESMTPSA id rt7sm19305377lbb.0.2014.02.17.07.21.05 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Feb 2014 07:21:06 -0800 (PST) From: Ulf Hansson To: Alessandro Rubini , Linus Walleij , Wolfram Sang , linux-i2c@vger.kernel.org Cc: Russell King , linux-arm-kernel@lists.infradead.org, Mark Brown , Ulf Hansson Subject: [PATCH V3 16/17] i2c: nomadik: Remove busy check for transfers at suspend late Date: Mon, 17 Feb 2014 16:21:02 +0100 Message-Id: <1392650462-14960-1-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ulf.hansson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We should never be busy performing transfers at suspend late, thus there are no reason to check for it. Cc: Alessandro Rubini Cc: Linus Walleij Cc: Wolfram Sang Signed-off-by: Ulf Hansson --- drivers/i2c/busses/i2c-nomadik.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 0a6d438..ceb3d05 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -167,7 +167,6 @@ struct i2c_nmk_client { * @stop: stop condition. * @xfer_complete: acknowledge completion for a I2C message. * @result: controller propogated result. - * @busy: Busy doing transfer. */ struct nmk_i2c_dev { struct i2c_vendor_data *vendor; @@ -185,7 +184,6 @@ struct nmk_i2c_dev { int stop; struct completion xfer_complete; int result; - bool busy; }; /* controller's abort causes */ @@ -671,8 +669,6 @@ static int nmk_i2c_xfer(struct i2c_adapter *i2c_adap, struct nmk_i2c_dev *dev = i2c_get_adapdata(i2c_adap); int j; - dev->busy = true; - pm_runtime_get_sync(&dev->adev->dev); /* Attempt three times to send the message queue */ @@ -697,8 +693,6 @@ static int nmk_i2c_xfer(struct i2c_adapter *i2c_adap, pm_runtime_put_sync(&dev->adev->dev); - dev->busy = false; - /* return the no. messages processed */ if (status) return status; @@ -888,9 +882,6 @@ static int nmk_i2c_suspend_late(struct device *dev) struct amba_device *adev = to_amba_device(dev); struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev); - if (nmk_i2c->busy) - return -EBUSY; - pinctrl_pm_select_sleep_state(dev); return 0; @@ -997,7 +988,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id) goto err_no_mem; } dev->vendor = vendor; - dev->busy = false; dev->adev = adev; nmk_i2c_of_probe(np, dev);