| Message ID | 1598363127-26066-1-git-send-email-loic.poulain@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | wcn36xx: Disable bmps when encryption is disabled | expand |
Loic Poulain <loic.poulain@linaro.org> wrote: > For whatever reason, when connected to an open/no-security BSS, > the wcn36xx controller in bmps mode does not forward 'wake-up' > beacons despite AP sends DTIM with station AID. > > Meaning that AP is not able to wakeup the station and needs to wait > for the station to wakeup by its own (TX data, keep alive pkt...), > causing serious latency issues and unexpected deauth. > > When connected to AP with encryption enabled, this issue does not occur. > So a simple workaround is to only enable bmps support in that case. > > Ideally, it should be propertly fixed to allow bmps support with open > BSS, whatever the issue is at driver or firmware level. > > Tested on wcn3620 and wcn3680. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. c6522a5076e1 wcn36xx: Disable bmps when encryption is disabled -- https://patchwork.kernel.org/patch/11735719/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx
Loic Poulain <loic.poulain@linaro.org> wrote: > For whatever reason, when connected to an open/no-security BSS, > the wcn36xx controller in bmps mode does not forward 'wake-up' > beacons despite AP sends DTIM with station AID. > > Meaning that AP is not able to wakeup the station and needs to wait > for the station to wakeup by its own (TX data, keep alive pkt...), > causing serious latency issues and unexpected deauth. > > When connected to AP with encryption enabled, this issue does not occur. > So a simple workaround is to only enable bmps support in that case. > > Ideally, it should be propertly fixed to allow bmps support with open > BSS, whatever the issue is at driver or firmware level. > > Tested on wcn3620 and wcn3680. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. c6522a5076e1 wcn36xx: Disable bmps when encryption is disabled -- https://patchwork.kernel.org/patch/11735719/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 2f36656..39d658c 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -610,6 +610,15 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, } } } + /* FIXME: Only enable bmps support when encryption is enabled. + * For any reasons, when connected to open/no-security BSS, + * the wcn36xx controller in bmps mode does not forward + * 'wake-up' beacons despite AP sends DTIM with station AID. + * It could be due to a firmware issue or to the way driver + * configure the station. + */ + if (vif->type == NL80211_IFTYPE_STATION) + vif_priv->allow_bmps = true; break; case DISABLE_KEY: if (!(IEEE80211_KEY_FLAG_PAIRWISE & key_conf->flags)) { @@ -891,6 +900,7 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw, vif->addr, bss_conf->aid); vif_priv->sta_assoc = false; + vif_priv->allow_bmps = false; wcn36xx_smd_set_link_st(wcn, bss_conf->bssid, vif->addr, diff --git a/drivers/net/wireless/ath/wcn36xx/pmc.c b/drivers/net/wireless/ath/wcn36xx/pmc.c index 2936aaf..2d0780f 100644 --- a/drivers/net/wireless/ath/wcn36xx/pmc.c +++ b/drivers/net/wireless/ath/wcn36xx/pmc.c @@ -23,7 +23,10 @@ int wcn36xx_pmc_enter_bmps_state(struct wcn36xx *wcn, { int ret = 0; struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif); - /* TODO: Make sure the TX chain clean */ + + if (!vif_priv->allow_bmps) + return -ENOTSUPP; + ret = wcn36xx_smd_enter_bmps(wcn, vif); if (!ret) { wcn36xx_dbg(WCN36XX_DBG_PMC, "Entered BMPS\n"); diff --git a/drivers/net/wireless/ath/wcn36xx/wcn36xx.h b/drivers/net/wireless/ath/wcn36xx/wcn36xx.h index 3221fed..719a6da 100644 --- a/drivers/net/wireless/ath/wcn36xx/wcn36xx.h +++ b/drivers/net/wireless/ath/wcn36xx/wcn36xx.h @@ -122,6 +122,7 @@ struct wcn36xx_vif { enum wcn36xx_hal_bss_type bss_type; /* Power management */ + bool allow_bmps; enum wcn36xx_power_state pw_state; u8 bss_index;