diff mbox series

net/mlx5e: kTLS, Fix GFP_KERNEL in spinlock context

Message ID 1599133539-175203-1-git-send-email-xuwei5@hisilicon.com
State New
Headers show
Series net/mlx5e: kTLS, Fix GFP_KERNEL in spinlock context | expand

Commit Message

Wei Xu Sept. 3, 2020, 11:45 a.m. UTC
Replace GFP_KERNEL with GFP_ATOMIC while resync_post_get_progress_params
is invoked in a spinlock context.
This code was detected with the help of Coccinelle.

Signed-off-by: Wei Xu <xuwei5@hisilicon.com>

---
 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.8.1

Comments

Wei Xu Sept. 3, 2020, 12:38 p.m. UTC | #1
Hi All,

Sorry for the noise and please ignore it!
I found a nearly same patch has been sent out 2 days before.

Best Regards,
Wei

On 2020/9/3 19:45, Wei Xu wrote:
> Replace GFP_KERNEL with GFP_ATOMIC while resync_post_get_progress_params

> is invoked in a spinlock context.

> This code was detected with the help of Coccinelle.

> 

> Signed-off-by: Wei Xu <xuwei5@hisilicon.com>

> ---

>  drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c

> index acf6d80..1a32435 100644

> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c

> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c

> @@ -247,7 +247,7 @@ resync_post_get_progress_params(struct mlx5e_icosq *sq,

>  	int err;

>  	u16 pi;

>  

> -	buf = kzalloc(sizeof(*buf), GFP_KERNEL);

> +	buf = kzalloc(sizeof(*buf), GFP_ATOMIC);

>  	if (unlikely(!buf)) {

>  		err = -ENOMEM;

>  		goto err_out;

>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c
index acf6d80..1a32435 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c
@@ -247,7 +247,7 @@  resync_post_get_progress_params(struct mlx5e_icosq *sq,
 	int err;
 	u16 pi;
 
-	buf = kzalloc(sizeof(*buf), GFP_KERNEL);
+	buf = kzalloc(sizeof(*buf), GFP_ATOMIC);
 	if (unlikely(!buf)) {
 		err = -ENOMEM;
 		goto err_out;