diff mbox series

ALSA: usb-audio: Add delay quirk for H570e USB headsets

Message ID 20200910085328.19188-1-joakim.tjernlund@infinera.com
State New
Headers show
Series ALSA: usb-audio: Add delay quirk for H570e USB headsets | expand

Commit Message

Joakim Tjernlund Sept. 10, 2020, 8:53 a.m. UTC
Needs the same delay as H650e

Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: stable@vger.kernel.org
---
 sound/usb/quirks.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Joakim Tjernlund Sept. 15, 2020, 1:54 p.m. UTC | #1
Ping? Was this accepted or dropped ?

   Joakim
On Thu, 2020-09-10 at 10:53 +0200, Joakim Tjernlund wrote:
> Needs the same delay as H650e

> 

> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>

> Cc: stable@vger.kernel.org

> ---

>  sound/usb/quirks.c | 7 ++++---

>  1 file changed, 4 insertions(+), 3 deletions(-)

> 

> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c

> index 75bbdc691243..892296df131d 100644

> --- a/sound/usb/quirks.c

> +++ b/sound/usb/quirks.c

> @@ -1678,12 +1678,13 @@ void snd_usb_ctl_msg_quirk(struct usb_device *dev, unsigned int pipe,

>  	    && (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)

>  		msleep(20);

>  

> 

> -	/* Zoom R16/24, Logitech H650e, Jabra 550a, Kingston HyperX needs a tiny

> -	 * delay here, otherwise requests like get/set frequency return as

> -	 * failed despite actually succeeding.

> +	/* Zoom R16/24, Logitech H650e/H570e, Jabra 550a, Kingston HyperX

> +	 *  needs a tiny delay here, otherwise requests like get/set

> +	 *  frequency return as failed despite actually succeeding.

>  	 */

>  	if ((chip->usb_id == USB_ID(0x1686, 0x00dd) ||

>  	     chip->usb_id == USB_ID(0x046d, 0x0a46) ||

> +	     chip->usb_id == USB_ID(0x046d, 0x0a56) ||

>  	     chip->usb_id == USB_ID(0x0b0e, 0x0349) ||

>  	     chip->usb_id == USB_ID(0x0951, 0x16ad)) &&

>  	    (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)
Takashi Iwai Sept. 21, 2020, 8:41 a.m. UTC | #2
On Thu, 10 Sep 2020 10:53:28 +0200,
Joakim Tjernlund wrote:
> 
> Needs the same delay as H650e
> 
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Cc: stable@vger.kernel.org

Applied now.  Thanks.


Takashi
diff mbox series

Patch

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 75bbdc691243..892296df131d 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1678,12 +1678,13 @@  void snd_usb_ctl_msg_quirk(struct usb_device *dev, unsigned int pipe,
 	    && (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)
 		msleep(20);
 
-	/* Zoom R16/24, Logitech H650e, Jabra 550a, Kingston HyperX needs a tiny
-	 * delay here, otherwise requests like get/set frequency return as
-	 * failed despite actually succeeding.
+	/* Zoom R16/24, Logitech H650e/H570e, Jabra 550a, Kingston HyperX
+	 *  needs a tiny delay here, otherwise requests like get/set
+	 *  frequency return as failed despite actually succeeding.
 	 */
 	if ((chip->usb_id == USB_ID(0x1686, 0x00dd) ||
 	     chip->usb_id == USB_ID(0x046d, 0x0a46) ||
+	     chip->usb_id == USB_ID(0x046d, 0x0a56) ||
 	     chip->usb_id == USB_ID(0x0b0e, 0x0349) ||
 	     chip->usb_id == USB_ID(0x0951, 0x16ad)) &&
 	    (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)