| Message ID | 1393193792-20008-3-git-send-email-julien.grall@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 02/24/2014 11:34 AM, Jan Beulich wrote: >>>> On 23.02.14 at 23:16, Julien Grall <julien.grall@linaro.org> wrote: >> iommu_domain_teardown is only used internally in >> xen/drivers/passthrough/vtd/iommu.c >> >> Signed-off-by: Julien Grall <julien.grall@linaro.org> >> Acked-by: Ian Cambell <ian.campbell@citrix.com> >> Cc: Xiantao Zhang <xiantao.zhang@intel.com> >> --- >> xen/drivers/passthrough/vtd/iommu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/drivers/passthrough/vtd/iommu.c >> b/xen/drivers/passthrough/vtd/iommu.c >> index 5f10034..a8d33fc 100644 >> --- a/xen/drivers/passthrough/vtd/iommu.c >> +++ b/xen/drivers/passthrough/vtd/iommu.c >> @@ -1701,7 +1701,7 @@ static int reassign_device_ownership( >> return ret; >> } >> >> -void iommu_domain_teardown(struct domain *d) >> +static void iommu_domain_teardown(struct domain *d) >> { >> struct hvm_iommu *hd = domain_hvm_iommu(d); >> > > Please build-test your changes - this was lacking the removal of > the function's declaration from xen/iommu.h. Actually I did the build test on x86 ... By mistake I remove the function's declaration in the wrong patch "xen/passthrough: iommu: Split generic IOMMU code". I will fix it in the next patch series. Cheers,
On 02/24/2014 12:18 PM, Jan Beulich wrote: > So I suppose you build tested the whole series, but not each > individual patch... I did on most of the patches. But forget to do it for trivial patches. >> I will fix it in the next patch series. > > In the sense that you need to drop the change from the later > patch then, as I applied the trivial three patches from the series > already. Thanks,
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 5f10034..a8d33fc 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -1701,7 +1701,7 @@ static int reassign_device_ownership( return ret; } -void iommu_domain_teardown(struct domain *d) +static void iommu_domain_teardown(struct domain *d) { struct hvm_iommu *hd = domain_hvm_iommu(d);