diff mbox series

[BlueZ] lib/sdp.c: Validate attribute search return value

Message ID 20200928064446.17803-1-machiry@cs.ucsb.edu
State New
Headers show
Series [BlueZ] lib/sdp.c: Validate attribute search return value | expand

Commit Message

Aravind Machiry Sept. 28, 2020, 6:44 a.m. UTC 
The calls to gen_[searchseq|attridseq]_seq functions return negative
value on failure. The return value should be checked to gracefully
exit with a proper exit code.
---
 lib/sdp.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Aravind Machiry Oct. 3, 2020, 6:11 p.m. UTC | #1 
Gentle reminder!

On Mon, Sep 28, 2020 at 12:32 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=356319
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - PASS
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth
>
Luiz Augusto von Dentz Oct. 7, 2020, 11:59 p.m. UTC | #2 
Hi,

On Sat, Oct 3, 2020 at 11:14 AM Aravind Machiry <machiry@cs.ucsb.edu> wrote:
>

> Gentle reminder!

>

> On Mon, Sep 28, 2020 at 12:32 AM <bluez.test.bot@gmail.com> wrote:

> >

> > This is automated email and please do not reply to this email!

> >

> > Dear submitter,

> >

> > Thank you for submitting the patches to the linux bluetooth mailing list.

> > This is a CI test results with your patch series:

> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=356319

> >

> > ---Test result---

> >

> > ##############################

> > Test: CheckPatch - PASS

> >

> > ##############################

> > Test: CheckGitLint - PASS

> >

> > ##############################

> > Test: CheckBuild - PASS

> >

> > ##############################

> > Test: MakeCheck - PASS

> >

> >

> >

> > ---

> > Regards,

> > Linux Bluetooth

> >


Applied, thanks.

-- 
Luiz Augusto von Dentz
diff mbox series

Patch

diff --git a/lib/sdp.c b/lib/sdp.c
index 532039a23..a27cd3a7b 100644
--- a/lib/sdp.c
+++ b/lib/sdp.c
@@ -3419,6 +3419,12 @@  int sdp_service_search_req(sdp_session_t *session, const sdp_list_t *search,
 	/* add service class IDs for search */
 	seqlen = gen_searchseq_pdu(pdata, search);
 
+	if (seqlen < 0) {
+		errno = EINVAL;
+		status = -1;
+		goto end;
+	}
+
 	SDPDBG("Data seq added : %d", seqlen);
 
 	/* set the length and increment the pointer */
@@ -3841,6 +3847,11 @@  int sdp_service_search_async(sdp_session_t *session, const sdp_list_t *search, u
 	/* add service class IDs for search */
 	seqlen = gen_searchseq_pdu(pdata, search);
 
+	if (seqlen < 0) {
+		t->err = EINVAL;
+		goto end;
+	}
+
 	SDPDBG("Data seq added : %d", seqlen);
 
 	/* now set the length and increment the pointer */
@@ -4054,6 +4065,11 @@  int sdp_service_search_attr_async(sdp_session_t *session, const sdp_list_t *sear
 	/* add service class IDs for search */
 	seqlen = gen_searchseq_pdu(pdata, search);
 
+	if (seqlen < 0) {
+		t->err = EINVAL;
+		goto end;
+	}
+
 	SDPDBG("Data seq added : %d", seqlen);
 
 	/* now set the length and increment the pointer */