| Message ID | 20200805193616.384313-2-vaibhavgupta40@gmail.com |
|---|---|
| State | Accepted |
| Commit | 536e785f533f5a65ce5238e202d527d70fd4ab17 |
| Headers | show |
| Series | i2c: eg20t: Power management upgrade and clean-ups | expand |
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c index 73f139690e4e..eb41de22d461 100644 --- a/drivers/i2c/busses/i2c-eg20t.c +++ b/drivers/i2c/busses/i2c-eg20t.c @@ -879,7 +879,6 @@ static int pch_i2c_suspend(struct pci_dev *pdev, pm_message_t state) return ret; } - pci_enable_wake(pdev, PCI_D3hot, 0); pci_disable_device(pdev); pci_set_power_state(pdev, pci_choose_state(pdev, state)); @@ -899,8 +898,6 @@ static int pch_i2c_resume(struct pci_dev *pdev) return -EIO; } - pci_enable_wake(pdev, PCI_D3hot, 0); - for (i = 0; i < adap_info->ch_num; i++) pch_i2c_init(&adap_info->pch_data[i]);
The driver calls pci_enable_wake(...., false) in pch_i2c_suspend() as well as pch_i2c_resume(). Either it should enable-wake the device in .suspend() or should not invoke pci_enable_wake() at all. Concluding that this driver doesn't support enable-wake and PCI core calls pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from .suspend() and .resume(). Reported-by: Bjorn Helgaas <helgaas@kernel.org> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> --- drivers/i2c/busses/i2c-eg20t.c | 3 --- 1 file changed, 3 deletions(-)