diff mbox series

HID: i2c-hid: Add 60ms delay after SET_POWER ON

Message ID 20200810142928.12552-1-kai.heng.feng@canonical.com
State New
Headers show
Series HID: i2c-hid: Add 60ms delay after SET_POWER ON | expand

Commit Message

Kai-Heng Feng Aug. 10, 2020, 2:29 p.m. UTC
Goodix touchpad fails to operate in I2C mode after system suspend.

According to the vendor, Windows is more forgiving and there's a 60ms
delay after SET_POWER ON command.

So let's do the same here, to workaround for the touchpads that depend
on the delay.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/hid/i2c-hid/i2c-hid-core.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 294c84e136d7..7b24a27fad95 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -419,6 +419,9 @@  static int i2c_hid_set_power(struct i2c_client *client, int power_state)
 	if (ret)
 		dev_err(&client->dev, "failed to change power setting.\n");
 
+	if (!ret && power_state == I2C_HID_PWR_ON)
+		msleep(60);
+
 set_pwr_exit:
 	return ret;
 }