| Message ID | 20200930234637.7573-3-post@lespocky.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds: pwm: Make automatic labels work | expand |
On Thu, 1 Oct 2020 at 01:52, Alexander Dahl <post@lespocky.de> wrote: > > The example was adapted in the following ways: > > - make use of the now supported 'function' and 'color' properties > - remove pwm nodes, those are documented elsewhere > - tweake node names to be matched by new dtschema rules tweak? or align? > > License was discussed with the original author. Since you relicense their work, you need an ack or signed off from every author. You cannot just say "I discussed" and post it. That way I could pretend (lie) I talked to Linus and try to relicense Linux to BSD... You need acks/SoB from Peter and Russel. Best regards, Krzysztof
Hei hei, Am Freitag, 2. Oktober 2020, 11:31:09 CEST schrieb Krzysztof Kozlowski: > On Thu, 1 Oct 2020 at 01:52, Alexander Dahl <post@lespocky.de> wrote: > > The example was adapted in the following ways: > > > > - make use of the now supported 'function' and 'color' properties > > - remove pwm nodes, those are documented elsewhere > > - tweake node names to be matched by new dtschema rules > > tweak? or align? Depends on if schema actually checks it (child nodes) or if it's just DT policy (parent node). I'll reword in v7. > > License was discussed with the original author. > > Since you relicense their work, you need an ack or signed off from > every author. You cannot just say "I discussed" and post it. That way > I could pretend (lie) I talked to Linus and try to relicense Linux to > BSD... I know. Peter promised to give his Ack publicly on the list back when I worked on v2 or v3, so he is in Cc since then, but apparently he did not yet post it. ;-) > You need acks/SoB from Peter and Russel. Well, I should add Russel in v7, too, then. Thanks Alex
On Fri, 2 Oct 2020 at 12:46, Alexander Dahl <ada@thorsis.com> wrote: > > Hei hei, > > Am Freitag, 2. Oktober 2020, 11:31:09 CEST schrieb Krzysztof Kozlowski: > > On Thu, 1 Oct 2020 at 01:52, Alexander Dahl <post@lespocky.de> wrote: > > > The example was adapted in the following ways: > > > > > > - make use of the now supported 'function' and 'color' properties > > > - remove pwm nodes, those are documented elsewhere > > > - tweake node names to be matched by new dtschema rules > > > > tweak? or align? > > Depends on if schema actually checks it (child nodes) or if it's just DT > policy (parent node). I'll reword in v7. > > > > License was discussed with the original author. > > > > Since you relicense their work, you need an ack or signed off from > > every author. You cannot just say "I discussed" and post it. That way > > I could pretend (lie) I talked to Linus and try to relicense Linux to > > BSD... > > I know. Peter promised to give his Ack publicly on the list back when I > worked on v2 or v3, so he is in Cc since then, but apparently he did not yet > post it. ;-) > > > You need acks/SoB from Peter and Russel. > > Well, I should add Russel in v7, too, then. Yes, please. For the patch itself: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Thu, 01 Oct 2020 01:46:32 +0200, Alexander Dahl wrote: > The example was adapted in the following ways: > > - make use of the now supported 'function' and 'color' properties > - remove pwm nodes, those are documented elsewhere > - tweake node names to be matched by new dtschema rules > > License was discussed with the original author. > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Alexander Dahl <post@lespocky.de> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > > Notes: > v5 -> v6: > * removed pwm nodes from example (Rob) > * renamed led-controller node in example (Rob) > > v4 -> v5: > * updated based on feedback by Rob Herring > * removed Acked-by > > v3 -> v4: > * added Cc to original author of the binding > > v2 -> v3: > * changed license identifier to recommended one > * added Acked-by > > v2: > * added this patch to series (Suggested-by: Jacek Anaszewski) > > .../devicetree/bindings/leds/leds-pwm.txt | 50 ------------- > .../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++ > 2 files changed, 70 insertions(+), 50 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt > create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-pwm.yaml See https://patchwork.ozlabs.org/patch/1374765 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Thu, 01 Oct 2020 01:46:32 +0200, Alexander Dahl wrote: > The example was adapted in the following ways: > > - make use of the now supported 'function' and 'color' properties > - remove pwm nodes, those are documented elsewhere > - tweake node names to be matched by new dtschema rules > > License was discussed with the original author. > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Alexander Dahl <post@lespocky.de> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > > Notes: > v5 -> v6: > * removed pwm nodes from example (Rob) > * renamed led-controller node in example (Rob) > > v4 -> v5: > * updated based on feedback by Rob Herring > * removed Acked-by > > v3 -> v4: > * added Cc to original author of the binding > > v2 -> v3: > * changed license identifier to recommended one > * added Acked-by > > v2: > * added this patch to series (Suggested-by: Jacek Anaszewski) > > .../devicetree/bindings/leds/leds-pwm.txt | 50 ------------- > .../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++ > 2 files changed, 70 insertions(+), 50 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt > create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt deleted file mode 100644 index 6c6583c35f2f..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt +++ /dev/null @@ -1,50 +0,0 @@ -LED connected to PWM - -Required properties: -- compatible : should be "pwm-leds". - -Each LED is represented as a sub-node of the pwm-leds device. Each -node's name represents the name of the corresponding LED. - -LED sub-node properties: -- pwms : PWM property to point to the PWM device (phandle)/port (id) and to - specify the period time to be used: <&phandle id period_ns>; -- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device - For the pwms and pwm-names property please refer to: - Documentation/devicetree/bindings/pwm/pwm.txt -- max-brightness : Maximum brightness possible for the LED -- active-low : (optional) For PWMs where the LED is wired to supply - rather than ground. -- label : (optional) - see Documentation/devicetree/bindings/leds/common.txt -- linux,default-trigger : (optional) - see Documentation/devicetree/bindings/leds/common.txt - -Example: - -twl_pwm: pwm { - /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */ - compatible = "ti,twl6030-pwm"; - #pwm-cells = <2>; -}; - -twl_pwmled: pwmled { - /* provides one PWM (id 0 for Charing indicator LED) */ - compatible = "ti,twl6030-pwmled"; - #pwm-cells = <2>; -}; - -pwmleds { - compatible = "pwm-leds"; - kpad { - label = "omap4::keypad"; - pwms = <&twl_pwm 0 7812500>; - max-brightness = <127>; - }; - - charging { - label = "omap4:green:chrg"; - pwms = <&twl_pwmled 0 7812500>; - max-brightness = <255>; - }; -}; diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml new file mode 100644 index 000000000000..fe4d5fd25913 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LEDs connected to PWM + +maintainers: + - Pavel Machek <pavel@ucw.cz> + +description: + Each LED is represented as a sub-node of the pwm-leds device. Each + node's name represents the name of the corresponding LED. + +properties: + compatible: + const: pwm-leds + +patternProperties: + "^led(-[0-9a-f]+)?$": + type: object + + $ref: common.yaml# + + properties: + pwms: + maxItems: 1 + + pwm-names: true + + max-brightness: + description: + Maximum brightness possible for the LED + $ref: /schemas/types.yaml#/definitions/uint32 + + active-low: + description: + For PWMs where the LED is wired to supply rather than ground. + type: boolean + + required: + - pwms + - max-brightness + +additionalProperties: false + +examples: + - | + + #include <dt-bindings/leds/common.h> + + led-controller { + compatible = "pwm-leds"; + + led-1 { + label = "omap4::keypad"; + pwms = <&twl_pwm 0 7812500>; + max-brightness = <127>; + }; + + led-2 { + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_CHARGING; + pwms = <&twl_pwmled 0 7812500>; + max-brightness = <255>; + }; + }; + +...
The example was adapted in the following ways: - make use of the now supported 'function' and 'color' properties - remove pwm nodes, those are documented elsewhere - tweake node names to be matched by new dtschema rules License was discussed with the original author. Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Signed-off-by: Alexander Dahl <post@lespocky.de> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> --- Notes: v5 -> v6: * removed pwm nodes from example (Rob) * renamed led-controller node in example (Rob) v4 -> v5: * updated based on feedback by Rob Herring * removed Acked-by v3 -> v4: * added Cc to original author of the binding v2 -> v3: * changed license identifier to recommended one * added Acked-by v2: * added this patch to series (Suggested-by: Jacek Anaszewski) .../devicetree/bindings/leds/leds-pwm.txt | 50 ------------- .../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++ 2 files changed, 70 insertions(+), 50 deletions(-) delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml