| Message ID | 20200915084000.2826741-1-yanaijie@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: isci: make scu_link_layer_set_txcomsas_timeout() static | expand |
Jason, > This addresses the following sparse warning: > > drivers/scsi/isci/phy.c:672:6: warning: symbol > 'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be > static? Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
On Tue, 15 Sep 2020 16:40:00 +0800, Jason Yan wrote: > This addresses the following sparse warning: > > drivers/scsi/isci/phy.c:672:6: warning: symbol > 'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be > static? Applied to 5.10/scsi-queue, thanks! [1/1] scsi: isci: Make scu_link_layer_set_txcomsas_timeout() static https://git.kernel.org/mkp/scsi/c/2494ebe1b3f7 -- Martin K. Petersen Oracle Linux Engineering
diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c index 4cacb800b530..7041e2e3ab48 100644 --- a/drivers/scsi/isci/phy.c +++ b/drivers/scsi/isci/phy.c @@ -669,7 +669,7 @@ static const char *phy_event_name(u32 event_code) phy_state_name(state), phy_event_name(code), code) -void scu_link_layer_set_txcomsas_timeout(struct isci_phy *iphy, u32 timeout) +static void scu_link_layer_set_txcomsas_timeout(struct isci_phy *iphy, u32 timeout) { u32 val;
This addresses the following sparse warning: drivers/scsi/isci/phy.c:672:6: warning: symbol 'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/scsi/isci/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)