[v1] Revert "serial: 8250: Let serial core initialise spin lock"

Message ID 20200802111612.36189-1-andriy.shevchenko@linux.intel.com
State New
Headers show
  • [v1] Revert "serial: 8250: Let serial core initialise spin lock"
Related show

Commit Message

Andy Shevchenko Aug. 2, 2020, 11:16 a.m.
This reverts commit 679193b7baf8d88e41cbeb397ca17f797654947d.

It appears that in QEmu the lock has been initialised differently
(it wasn't obvious on real hardware during testing). Let's
revert the change until the better approach will be developed.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
 drivers/tty/serial/8250/8250_port.c | 1 +
 1 file changed, 1 insertion(+)


diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index b2d18189d3d9..09475695effd 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -3194,6 +3194,7 @@  void serial8250_init_port(struct uart_8250_port *up)
 	struct uart_port *port = &up->port;
+	spin_lock_init(&port->lock);
 	port->ops = &serial8250_pops;
 	port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);