diff mbox series

usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root

Message ID 1600061930-778-1-git-send-email-chunfeng.yun@mediatek.com
State Superseded
Headers show
Series usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root | expand

Commit Message

Chunfeng Yun (云春峰) Sept. 14, 2020, 5:38 a.m. UTC
Fix up the build error caused by undeclared usb_debug_root

Cc: stable <stable@vger.kernel.org>
Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

---
 drivers/usb/gadget/udc/bcm63xx_udc.c | 1 +
 1 file changed, 1 insertion(+)

-- 
1.9.1

Comments

Greg KH Sept. 14, 2020, 6:12 a.m. UTC | #1
On Mon, Sep 14, 2020 at 01:38:50PM +0800, Chunfeng Yun wrote:
> Fix up the build error caused by undeclared usb_debug_root
> 
> Cc: stable <stable@vger.kernel.org>
> Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")

Nit, you need a ' ' before the '(' character...

thanks,

greg k-h
Felipe Balbi Sept. 24, 2020, 7:50 a.m. UTC | #2
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:

> Fix up the build error caused by undeclared usb_debug_root
>
> Cc: stable <stable@vger.kernel.org>
> Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

$ patch -p1 --dry-run p.patch
/usr/bin/patch: **** Only garbage was found in the patch input.
Chunfeng Yun (云春峰) Sept. 24, 2020, 8:28 a.m. UTC | #3
On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote:
> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:

> 

> > Fix up the build error caused by undeclared usb_debug_root

> >

> > Cc: stable <stable@vger.kernel.org>

> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")

> > Reported-by: kernel test robot <lkp@intel.com>

> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

> 

> $ patch -p1 --dry-run p.patch

> /usr/bin/patch: **** Only garbage was found in the patch input.

> 

Please try to apply v2, https://patchwork.kernel.org/patch/11772911/
I indeed add a line code
Felipe Balbi Sept. 24, 2020, 8:52 a.m. UTC | #4
Hi,

Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote:
>> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
>> 
>> > Fix up the build error caused by undeclared usb_debug_root
>> >
>> > Cc: stable <stable@vger.kernel.org>
>> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
>> > Reported-by: kernel test robot <lkp@intel.com>
>> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>> 
>> $ patch -p1 --dry-run p.patch
>> /usr/bin/patch: **** Only garbage was found in the patch input.
>> 
> Please try to apply v2, https://patchwork.kernel.org/patch/11772911/
> I indeed add a line code

that worked, but the problem I have is that your patches always come
base64 encoded. Make sure they come as plain text in the future :-)
diff mbox series

Patch

diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c
index feaec00..9cd4a70 100644
--- a/drivers/usb/gadget/udc/bcm63xx_udc.c
+++ b/drivers/usb/gadget/udc/bcm63xx_udc.c
@@ -26,6 +26,7 @@ 
 #include <linux/seq_file.h>
 #include <linux/slab.h>
 #include <linux/timer.h>
+#include <linux/usb.h>
 #include <linux/usb/ch9.h>
 #include <linux/usb/gadget.h>
 #include <linux/workqueue.h>