diff mbox series

[net-next,1/1] net/smc: fix double kfree in smc_listen_work()

Message ID 20200917204602.14586-2-kgraul@linux.ibm.com
State New
Headers show
Series [net-next,1/1] net/smc: fix double kfree in smc_listen_work() | expand

Commit Message

Karsten Graul Sept. 17, 2020, 8:46 p.m. UTC 
From: Ursula Braun <ubraun@linux.ibm.com>

If smc_listen_rmda_finish() returns with an error, the storage
addressed by 'buf' is freed a second time.
Consolidate freeing under a common label and jump to that label.

Fixes: 6bb14e48ee8d ("net/smc: dynamic allocation of CLC proposal buffer")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
---
 net/smc/af_smc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Sept. 18, 2020, 1:04 a.m. UTC | #1 
From: Karsten Graul <kgraul@linux.ibm.com>
Date: Thu, 17 Sep 2020 22:46:02 +0200

> From: Ursula Braun <ubraun@linux.ibm.com>
> 
> If smc_listen_rmda_finish() returns with an error, the storage
> addressed by 'buf' is freed a second time.
> Consolidate freeing under a common label and jump to that label.
> 
> Fixes: 6bb14e48ee8d ("net/smc: dynamic allocation of CLC proposal buffer")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
> Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>

Applied.
diff mbox series

Patch

diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index f5bececfedaa..ed8f97166be9 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1371,7 +1371,6 @@  static void smc_listen_work(struct work_struct *work)
 	}
 
 	/* finish worker */
-	kfree(buf);
 	if (!ism_supported) {
 		rc = smc_listen_rdma_finish(new_smc, &cclc,
 					    ini.first_contact_local);
@@ -1381,12 +1380,13 @@  static void smc_listen_work(struct work_struct *work)
 	}
 	smc_conn_save_peer_info(new_smc, &cclc);
 	smc_listen_out_connected(new_smc);
-	return;
+	goto out_free;
 
 out_unlock:
 	mutex_unlock(&smc_server_lgr_pending);
 out_decl:
 	smc_listen_decline(new_smc, rc, ini.first_contact_local);
+out_free:
 	kfree(buf);
 }