diff mbox series

[1/2] mm: replace memmap_context by memplug_context

Message ID 20200929135738.28697-1-ldufour@linux.ibm.com
State New
Headers show
Series [1/2] mm: replace memmap_context by memplug_context | expand

Commit Message

Laurent Dufour Sept. 29, 2020, 1:57 p.m. UTC
Backport version to the 5.4-stable tree of the commit:

c1d0da83358a ("mm: replace memmap_context by meminit_context")

Cc: <stable@vger.kernel.org> # 5.4.y
Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
---
 arch/ia64/mm/init.c    |  6 +++---
 include/linux/mm.h     |  2 +-
 include/linux/mmzone.h | 11 ++++++++---
 mm/memory_hotplug.c    |  2 +-
 mm/page_alloc.c        | 10 +++++-----
 5 files changed, 18 insertions(+), 13 deletions(-)

Comments

Greg KH Sept. 29, 2020, 2:29 p.m. UTC | #1
On Tue, Sep 29, 2020 at 03:57:37PM +0200, Laurent Dufour wrote:
> Backport version to the 5.4-stable tree of the commit:

> 

> c1d0da83358a ("mm: replace memmap_context by meminit_context")

> 

> Cc: <stable@vger.kernel.org> # 5.4.y

> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>


What happened to the full changelog from the original commit, and all of
the cc: and signed-off-by from it?

Please include that in the patch, you don't want to see all of that
stripped off, right?

thanks,

greg k-h
Laurent Dufour Sept. 29, 2020, 3:31 p.m. UTC | #2
Le 29/09/2020 à 16:29, Greg KH a écrit :
> On Tue, Sep 29, 2020 at 03:57:37PM +0200, Laurent Dufour wrote:

>> Backport version to the 5.4-stable tree of the commit:

>>

>> c1d0da83358a ("mm: replace memmap_context by meminit_context")

>>

>> Cc: <stable@vger.kernel.org> # 5.4.y

>> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>

> 

> What happened to the full changelog from the original commit, and all of

> the cc: and signed-off-by from it?

> 

> Please include that in the patch, you don't want to see all of that

> stripped off, right?


Sorry, I was thinking some magic script was pulling the original commit 
description based on the git commit id ;)

I'll send the patches again.
Is there a specific tag to use when mentioning the original commit id?

Thanks,
Laurent.
Greg KH Sept. 29, 2020, 4:03 p.m. UTC | #3
On Tue, Sep 29, 2020 at 05:31:50PM +0200, Laurent Dufour wrote:
> Le 29/09/2020 à 16:29, Greg KH a écrit :
> > On Tue, Sep 29, 2020 at 03:57:37PM +0200, Laurent Dufour wrote:
> > > Backport version to the 5.4-stable tree of the commit:
> > > 
> > > c1d0da83358a ("mm: replace memmap_context by meminit_context")
> > > 
> > > Cc: <stable@vger.kernel.org> # 5.4.y
> > > Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> > 
> > What happened to the full changelog from the original commit, and all of
> > the cc: and signed-off-by from it?
> > 
> > Please include that in the patch, you don't want to see all of that
> > stripped off, right?
> 
> Sorry, I was thinking some magic script was pulling the original commit
> description based on the git commit id ;)
> 
> I'll send the patches again.
> Is there a specific tag to use when mentioning the original commit id?

You can copy the format we use when committing the patch to a stable
tree if you want to be nice.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c
index a6dd80a2c939..ee50506d86f4 100644
--- a/arch/ia64/mm/init.c
+++ b/arch/ia64/mm/init.c
@@ -518,7 +518,7 @@  virtual_memmap_init(u64 start, u64 end, void *arg)
 	if (map_start < map_end)
 		memmap_init_zone((unsigned long)(map_end - map_start),
 				 args->nid, args->zone, page_to_pfn(map_start),
-				 MEMMAP_EARLY, NULL);
+				 MEMINIT_EARLY, NULL);
 	return 0;
 }
 
@@ -527,8 +527,8 @@  memmap_init (unsigned long size, int nid, unsigned long zone,
 	     unsigned long start_pfn)
 {
 	if (!vmem_map) {
-		memmap_init_zone(size, nid, zone, start_pfn, MEMMAP_EARLY,
-				NULL);
+		memmap_init_zone(size, nid, zone, start_pfn,
+				 MEMINIT_EARLY, NULL);
 	} else {
 		struct page *start;
 		struct memmap_init_callback_data args;
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 3285dae06c03..34119f393a80 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2208,7 +2208,7 @@  static inline void zero_resv_unavail(void) {}
 
 extern void set_dma_reserve(unsigned long new_dma_reserve);
 extern void memmap_init_zone(unsigned long, int, unsigned long, unsigned long,
-		enum memmap_context, struct vmem_altmap *);
+		enum meminit_context, struct vmem_altmap *);
 extern void setup_per_zone_wmarks(void);
 extern int __meminit init_per_zone_wmark_min(void);
 extern void mem_init(void);
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 85804ba62215..a90aba3d6afb 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -822,10 +822,15 @@  bool zone_watermark_ok(struct zone *z, unsigned int order,
 		unsigned int alloc_flags);
 bool zone_watermark_ok_safe(struct zone *z, unsigned int order,
 		unsigned long mark, int classzone_idx);
-enum memmap_context {
-	MEMMAP_EARLY,
-	MEMMAP_HOTPLUG,
+/*
+ * Memory initialization context, use to differentiate memory added by
+ * the platform statically or via memory hotplug interface.
+ */
+enum meminit_context {
+	MEMINIT_EARLY,
+	MEMINIT_HOTPLUG,
 };
+
 extern void init_currently_empty_zone(struct zone *zone, unsigned long start_pfn,
 				     unsigned long size);
 
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 3eb0b311b4a1..6a4b3a01e1b6 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -725,7 +725,7 @@  void __ref move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn,
 	 * are reserved so nobody should be touching them so we should be safe
 	 */
 	memmap_init_zone(nr_pages, nid, zone_idx(zone), start_pfn,
-			MEMMAP_HOTPLUG, altmap);
+			 MEMINIT_HOTPLUG, altmap);
 
 	set_zone_contiguous(zone);
 }
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 67a9943aa595..373ca5780758 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5875,7 +5875,7 @@  overlap_memmap_init(unsigned long zone, unsigned long *pfn)
  * done. Non-atomic initialization, single-pass.
  */
 void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
-		unsigned long start_pfn, enum memmap_context context,
+		unsigned long start_pfn, enum meminit_context context,
 		struct vmem_altmap *altmap)
 {
 	unsigned long pfn, end_pfn = start_pfn + size;
@@ -5907,7 +5907,7 @@  void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
 		 * There can be holes in boot-time mem_map[]s handed to this
 		 * function.  They do not exist on hotplugged memory.
 		 */
-		if (context == MEMMAP_EARLY) {
+		if (context == MEMINIT_EARLY) {
 			if (!early_pfn_valid(pfn))
 				continue;
 			if (!early_pfn_in_nid(pfn, nid))
@@ -5920,7 +5920,7 @@  void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
 
 		page = pfn_to_page(pfn);
 		__init_single_page(page, pfn, zone, nid);
-		if (context == MEMMAP_HOTPLUG)
+		if (context == MEMINIT_HOTPLUG)
 			__SetPageReserved(page);
 
 		/*
@@ -6002,7 +6002,7 @@  void __ref memmap_init_zone_device(struct zone *zone,
 		 * check here not to call set_pageblock_migratetype() against
 		 * pfn out of zone.
 		 *
-		 * Please note that MEMMAP_HOTPLUG path doesn't clear memmap
+		 * Please note that MEMINIT_HOTPLUG path doesn't clear memmap
 		 * because this is done early in section_activate()
 		 */
 		if (!(pfn & (pageblock_nr_pages - 1))) {
@@ -6028,7 +6028,7 @@  static void __meminit zone_init_free_lists(struct zone *zone)
 void __meminit __weak memmap_init(unsigned long size, int nid,
 				  unsigned long zone, unsigned long start_pfn)
 {
-	memmap_init_zone(size, nid, zone, start_pfn, MEMMAP_EARLY, NULL);
+	memmap_init_zone(size, nid, zone, start_pfn, MEMINIT_EARLY, NULL);
 }
 
 static int zone_batchsize(struct zone *zone)