diff mbox

[Xen-devel] xen/arm: Guard correctly asm-arm/platforms/exynos5.h

Message ID 1395264146-12698-1-git-send-email-julien.grall@linaro.org
State Superseded, archived
Headers show

Commit Message

Julien Grall March 19, 2014, 9:22 p.m. UTC
Fix compilation with clang 3.5:

/local/home/julien/works/arndale/xen/xen/include/asm/platforms/exynos5.h:1:9: error: '__ASM_ARM_PLATFORMS_EXYNOS5_H' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/local/home/julien/works/arndale/xen/xen/include/asm/platforms/exynos5.h:2:9: note: '__ASM_ASM_PLATFORMS_EXYSNO5_H' is defined here; did you mean '__ASM_ARM_PLATFORMS_EXYNOS5_H'?
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __ASM_ARM_PLATFORMS_EXYNOS5_H

Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
 xen/include/asm-arm/platforms/exynos5.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Julien Grall March 19, 2014, 9:27 p.m. UTC | #1
On 03/19/2014 09:22 PM, Julien Grall wrote:
> Fix compilation with clang 3.5:
> 
> /local/home/julien/works/arndale/xen/xen/include/asm/platforms/exynos5.h:1:9: error: '__ASM_ARM_PLATFORMS_EXYNOS5_H' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /local/home/julien/works/arndale/xen/xen/include/asm/platforms/exynos5.h:2:9: note: '__ASM_ASM_PLATFORMS_EXYSNO5_H' is defined here; did you mean '__ASM_ARM_PLATFORMS_EXYNOS5_H'?
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>         __ASM_ARM_PLATFORMS_EXYNOS5_H
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> ---
>  xen/include/asm-arm/platforms/exynos5.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/platforms/exynos5.h b/xen/include/asm-arm/platforms/exynos5.h
> index af30608..2f0866d 100644
> --- a/xen/include/asm-arm/platforms/exynos5.h
> +++ b/xen/include/asm-arm/platforms/exynos5.h
> @@ -1,5 +1,5 @@
>  #ifndef __ASM_ARM_PLATFORMS_EXYNOS5_H
> -#define __ASM_ASM_PLATFORMS_EXYSNO5_H
> +#define __ASM_ARM_PLATFORMS_EXYSNO5_H

Actually there was 2 errors in guard. I have sent another version.
diff mbox

Patch

diff --git a/xen/include/asm-arm/platforms/exynos5.h b/xen/include/asm-arm/platforms/exynos5.h
index af30608..2f0866d 100644
--- a/xen/include/asm-arm/platforms/exynos5.h
+++ b/xen/include/asm-arm/platforms/exynos5.h
@@ -1,5 +1,5 @@ 
 #ifndef __ASM_ARM_PLATFORMS_EXYNOS5_H
-#define __ASM_ASM_PLATFORMS_EXYSNO5_H
+#define __ASM_ARM_PLATFORMS_EXYSNO5_H
 
 #define EXYNOS5_MCT_BASE            0x101c0000
 #define EXYNOS5_MCT_G_TCON          0x240       /* Relative to MCT_BASE */