| Message ID | 20201002140545.477481-1-angelo.dureghello@timesys.com |
|---|---|
| State | New |
| Headers | show |
| Series | serial: mcf: add sysrq capability | expand |
Hi Angelo, On 3/10/20 12:05 am, Angelo Dureghello wrote: > After some unsuccessful attempts to use sysrq over console, figured > out that port->has_sysrq should likely be enabled, as per other > architectures, this when CONFIG_SERIAL_MCF_CONSOLE is also enabled. > > Tested some magic sysrq commands (h, p, t, b), they works now > properly. Commands works inside 5 secs after BREAK is sent, as > expected. > > Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com> Acked-by: Greg Ungerer <gerg@linux-m68k.org> I can take this via the m68knommu git tree if no one else wants to pick it up? Regards Greg > --- > drivers/tty/serial/mcf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c > index 7dbfb4cde124..09c88c48fb7b 100644 > --- a/drivers/tty/serial/mcf.c > +++ b/drivers/tty/serial/mcf.c > @@ -632,6 +632,7 @@ static int mcf_probe(struct platform_device *pdev) > port->ops = &mcf_uart_ops; > port->flags = UPF_BOOT_AUTOCONF; > port->rs485_config = mcf_config_rs485; > + port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MCF_CONSOLE); > > uart_add_one_port(&mcf_driver, port); > } >
diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c index 7dbfb4cde124..09c88c48fb7b 100644 --- a/drivers/tty/serial/mcf.c +++ b/drivers/tty/serial/mcf.c @@ -632,6 +632,7 @@ static int mcf_probe(struct platform_device *pdev) port->ops = &mcf_uart_ops; port->flags = UPF_BOOT_AUTOCONF; port->rs485_config = mcf_config_rs485; + port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MCF_CONSOLE); uart_add_one_port(&mcf_driver, port); }
After some unsuccessful attempts to use sysrq over console, figured out that port->has_sysrq should likely be enabled, as per other architectures, this when CONFIG_SERIAL_MCF_CONSOLE is also enabled. Tested some magic sysrq commands (h, p, t, b), they works now properly. Commands works inside 5 secs after BREAK is sent, as expected. Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com> --- drivers/tty/serial/mcf.c | 1 + 1 file changed, 1 insertion(+)