| Message ID | 1869e1c3-cf1e-a851-77ac-5482c694f5b3@free.fr |
|---|---|
| State | New |
| Headers | show |
| Series | iproute2: ip addr: Fix noprefixroute and autojoin for IPv4 | expand |
On Sat, 3 Oct 2020 16:10:05 +0200 Adel Belhouane <bugs.a.b@free.fr> wrote: > These were reported as IPv6-only and ignored: > > # ip address add 192.0.2.2/24 dev dummy5 noprefixroute > Warning: noprefixroute option can be set only for IPv6 addresses > # ip address add 224.1.1.10/24 dev dummy5 autojoin > Warning: autojoin option can be set only for IPv6 addresses > > This enables them back for IPv4. > > Fixes: 9d59c86e575b5 ("iproute2: ip addr: Organize flag properties > structurally") > Signed-off-by: Adel Belhouane <bugs.a.b@free.fr> Thanks, your patch was corrupted by mail and would not apply. Did the same change manually and kept your SOB
diff --git a/ip/ipaddress.c b/ip/ipaddress.c index ccf67d1dd55c..2b4cb48a485e 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -1249,8 +1249,8 @@ static const struct ifa_flag_data_t { { .name = "tentative", .mask = IFA_F_TENTATIVE, .readonly = true, .v6only = true}, { .name = "permanent", .mask = IFA_F_PERMANENT, .readonly = true, .v6only = true}, { .name = "mngtmpaddr", .mask = IFA_F_MANAGETEMPADDR, .readonly = false, .v6only = true}, - { .name = "noprefixroute", .mask = IFA_F_NOPREFIXROUTE, .readonly = false, .v6only = true}, - { .name = "autojoin", .mask = IFA_F_MCAUTOJOIN, .readonly = false, .v6only = true}, + { .name = "noprefixroute", .mask = IFA_F_NOPREFIXROUTE, .readonly = false, .v6only = false}, + { .name = "autojoin", .mask = IFA_F_MCAUTOJOIN, .readonly = false, .v6only = false}, { .name = "stable-privacy", .mask = IFA_F_STABLE_PRIVACY, .readonly = true, .v6only = true}, };
These were reported as IPv6-only and ignored: # ip address add 192.0.2.2/24 dev dummy5 noprefixroute Warning: noprefixroute option can be set only for IPv6 addresses # ip address add 224.1.1.10/24 dev dummy5 autojoin Warning: autojoin option can be set only for IPv6 addresses This enables them back for IPv4. Fixes: 9d59c86e575b5 ("iproute2: ip addr: Organize flag properties structurally") Signed-off-by: Adel Belhouane <bugs.a.b@free.fr> --- ip/ipaddress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)