| Message ID | 4688927cbf36fe0027340ea5e0c3aaf1445ba256.1601715478.git.wilken.gottwalt@mailbox.org |
|---|---|
| State | New |
| Headers | show |
| Series | add Cellient MPL200 card | expand |
Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes: > Add usb ids of the Cellient MPL200 card. > > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org> > --- > drivers/net/usb/qmi_wwan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 07c42c0719f5..0bf2b19d5d54 100644 > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c This is not a 'usb: serial' driver. Please resend with a less confusing subject prefix. > @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = { > {QMI_GOBI_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */ > {QMI_GOBI_DEVICE(0x12d1, 0x14f1)}, /* Sony Gobi 3000 Composite */ > {QMI_GOBI_DEVICE(0x1410, 0xa021)}, /* Foxconn Gobi 3000 Modem device (Novatel E396) */ > + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm 0x05c6) */ > > { } /* END */ > }; This table is supposed to be organized by device type. The last section is for Gobi2k and Gobi3k devices. Please try to put new devices into the correct section. Thanks Bjørn
On Sun, 04 Oct 2020 17:29:38 +0200 Bjørn Mork <bjorn@mork.no> wrote: > Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes: > > > Add usb ids of the Cellient MPL200 card. > > > > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org> > > --- > > drivers/net/usb/qmi_wwan.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > > index 07c42c0719f5..0bf2b19d5d54 100644 > > --- a/drivers/net/usb/qmi_wwan.c > > +++ b/drivers/net/usb/qmi_wwan.c > > This is not a 'usb: serial' driver. Please resend with a less confusing > subject prefix. > > > @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = { > > {QMI_GOBI_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */ > > {QMI_GOBI_DEVICE(0x12d1, 0x14f1)}, /* Sony Gobi 3000 Composite */ > > {QMI_GOBI_DEVICE(0x1410, 0xa021)}, /* Foxconn Gobi 3000 Modem device (Novatel > > E396) */ > > + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm > > 0x05c6) */ > > { } /* END */ > > }; > > > This table is supposed to be organized by device type. The last section > is for Gobi2k and Gobi3k devices. Please try to put new devices into > the correct section. Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit a patch set. Which is the best way to resubmit an update if the other part of the patch set gets accepted? The documentation about re-/submitting patch sets is a bit thin. Will
On Sun, Oct 04, 2020 at 08:30:42PM +0200, Wilken Gottwalt wrote: > On Sun, 04 Oct 2020 17:29:38 +0200 > Bjørn Mork <bjorn@mork.no> wrote: > > > Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes: > > > > > Add usb ids of the Cellient MPL200 card. > > > > > > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org> > > > --- > > > drivers/net/usb/qmi_wwan.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > > > index 07c42c0719f5..0bf2b19d5d54 100644 > > > --- a/drivers/net/usb/qmi_wwan.c > > > +++ b/drivers/net/usb/qmi_wwan.c > > > > This is not a 'usb: serial' driver. Please resend with a less confusing > > subject prefix. > > > > > @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = { > > > {QMI_GOBI_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */ > > > {QMI_GOBI_DEVICE(0x12d1, 0x14f1)}, /* Sony Gobi 3000 Composite */ > > > {QMI_GOBI_DEVICE(0x1410, 0xa021)}, /* Foxconn Gobi 3000 Modem device (Novatel > > > E396) */ > > > + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm > > > 0x05c6) */ > > > { } /* END */ > > > }; > > > > > > This table is supposed to be organized by device type. The last section > > is for Gobi2k and Gobi3k devices. Please try to put new devices into > > the correct section. > > Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit > a patch set. Which is the best way to resubmit an update if the other part of > the patch set gets accepted? The documentation about re-/submitting patch sets > is a bit thin. Just send these as individual patches (not a series) as they are independent and go through separate trees. Also, I never received the USB serial patch, only this one, so you need to resend both anyway. Johan
On Mon, Oct 05, 2020 at 10:06:12AM +0200, Johan Hovold wrote: > On Sun, Oct 04, 2020 at 08:30:42PM +0200, Wilken Gottwalt wrote: > > Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit > > a patch set. Which is the best way to resubmit an update if the other part of > > the patch set gets accepted? The documentation about re-/submitting patch sets > > is a bit thin. > > Just send these as individual patches (not a series) as they are > independent and go through separate trees. > > Also, I never received the USB serial patch, only this one, so you need > to resend both anyway. Found it flagged spam, so no need to resend that one. Just resend the networking one with a v2 prefix. In general, you could mention in a changelog in the cover letter that you've removed patches that have already been applied. Johan
Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes: > Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit > a patch set. Which is the best way to resubmit an update if the other part of > the patch set gets accepted? The documentation about re-/submitting patch sets > is a bit thin. I see that Johan already has answered this. Just wanted to add that you don't need to worry about doing anything wrong. It was not my intention to scare you :-) Fixing up and resending patches is a natural part of the patch submission process. Don't be afraid to resubmit. The worst that can happen is that you'll be asked to fix up something else. That's not a problem. The most important part is to make it clear that a resubmission replaces an earlier version of the same patch. This should be visible in the subject. E.g by using a revision number inside the brackes, like [PATCH v2] net: qmi_wwan: add Cellient MPL200 card This tells us that the patch is a revised "v2" of an earlier patch, and that it replaces "v1". Patches without an explicit revision will then be assumed to be "v1". If you are sending a series, then the whole series should usually be resubmitted with the new revsion number. Even patches without any changes. The cover letter should then also summarize the changes for each revisions. But as Johan said: The USB serial and net patches go through different trees and are therefore best handled as standalone patches, even if they deal with the same USB composite device. Bjørn
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 07c42c0719f5..0bf2b19d5d54 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = { {QMI_GOBI_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */ {QMI_GOBI_DEVICE(0x12d1, 0x14f1)}, /* Sony Gobi 3000 Composite */ {QMI_GOBI_DEVICE(0x1410, 0xa021)}, /* Foxconn Gobi 3000 Modem device (Novatel E396) */ + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm 0x05c6) */ { } /* END */ };
Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org> --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+)