| Message ID | 20201005111644.3131604-2-primoz.fiser@norik.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] ASoC: fsl: fsl_ssi: add ac97 fixed mode support | expand |
On Mon, Oct 5, 2020 at 8:16 AM Primoz Fiser <primoz.fiser@norik.com> wrote: > > Add devicetree bindings documentation for operating SSI in AC'97 > variable/fixed mode of operation. > > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> > --- > Documentation/devicetree/bindings/sound/fsl,ssi.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,ssi.txt b/Documentation/devicetree/bindings/sound/fsl,ssi.txt > index 7e15a85cecd2..abc5abe11fb9 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,ssi.txt > +++ b/Documentation/devicetree/bindings/sound/fsl,ssi.txt > @@ -43,6 +43,11 @@ Optional properties: > - fsl,mode: The operating mode for the AC97 interface only. > "ac97-slave" - AC97 mode, SSI is clock slave > "ac97-master" - AC97 mode, SSI is clock master > +- fsl,ac97-mode: SSI AC97 mode of operation. > + "variable" - AC97 Variable Mode, SLOTREQ bits determine > + next receive/transmit frame > + "fixed" - AC97 Fixed Mode, SSI transmits in accordance with > + AC97 Frame Rate Divider bits It would be good to mention what is the default mode when such property is absent.
On Mon, Oct 05, 2020 at 08:35:58AM -0300, Fabio Estevam wrote: > On Mon, Oct 5, 2020 at 8:16 AM Primoz Fiser <primoz.fiser@norik.com> wrote: > > > > Add devicetree bindings documentation for operating SSI in AC'97 > > variable/fixed mode of operation. > > > > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> > > --- > > Documentation/devicetree/bindings/sound/fsl,ssi.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,ssi.txt b/Documentation/devicetree/bindings/sound/fsl,ssi.txt > > index 7e15a85cecd2..abc5abe11fb9 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl,ssi.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl,ssi.txt > > @@ -43,6 +43,11 @@ Optional properties: > > - fsl,mode: The operating mode for the AC97 interface only. > > "ac97-slave" - AC97 mode, SSI is clock slave > > "ac97-master" - AC97 mode, SSI is clock master > > +- fsl,ac97-mode: SSI AC97 mode of operation. > > + "variable" - AC97 Variable Mode, SLOTREQ bits determine > > + next receive/transmit frame > > + "fixed" - AC97 Fixed Mode, SSI transmits in accordance with > > + AC97 Frame Rate Divider bits > > It would be good to mention what is the default mode when such > property is absent. Then perhaps it could be boolean? Rob
Hi, > Then perhaps it could be boolean? Indeed, I can make it boolean. In that case I would rename property to "fsl,ac97-fixed-mode". Should I do that for V2? Please advise. BR, Primoz On 6. 10. 20 23:52, Rob Herring wrote: > On Mon, Oct 05, 2020 at 08:35:58AM -0300, Fabio Estevam wrote: >> On Mon, Oct 5, 2020 at 8:16 AM Primoz Fiser <primoz.fiser@norik.com> wrote: >>> >>> Add devicetree bindings documentation for operating SSI in AC'97 >>> variable/fixed mode of operation. >>> >>> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> >>> --- >>> Documentation/devicetree/bindings/sound/fsl,ssi.txt | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/fsl,ssi.txt b/Documentation/devicetree/bindings/sound/fsl,ssi.txt >>> index 7e15a85cecd2..abc5abe11fb9 100644 >>> --- a/Documentation/devicetree/bindings/sound/fsl,ssi.txt >>> +++ b/Documentation/devicetree/bindings/sound/fsl,ssi.txt >>> @@ -43,6 +43,11 @@ Optional properties: >>> - fsl,mode: The operating mode for the AC97 interface only. >>> "ac97-slave" - AC97 mode, SSI is clock slave >>> "ac97-master" - AC97 mode, SSI is clock master >>> +- fsl,ac97-mode: SSI AC97 mode of operation. >>> + "variable" - AC97 Variable Mode, SLOTREQ bits determine >>> + next receive/transmit frame >>> + "fixed" - AC97 Fixed Mode, SSI transmits in accordance with >>> + AC97 Frame Rate Divider bits >> >> It would be good to mention what is the default mode when such >> property is absent. > > Then perhaps it could be boolean? > > Rob >
diff --git a/Documentation/devicetree/bindings/sound/fsl,ssi.txt b/Documentation/devicetree/bindings/sound/fsl,ssi.txt index 7e15a85cecd2..abc5abe11fb9 100644 --- a/Documentation/devicetree/bindings/sound/fsl,ssi.txt +++ b/Documentation/devicetree/bindings/sound/fsl,ssi.txt @@ -43,6 +43,11 @@ Optional properties: - fsl,mode: The operating mode for the AC97 interface only. "ac97-slave" - AC97 mode, SSI is clock slave "ac97-master" - AC97 mode, SSI is clock master +- fsl,ac97-mode: SSI AC97 mode of operation. + "variable" - AC97 Variable Mode, SLOTREQ bits determine + next receive/transmit frame + "fixed" - AC97 Fixed Mode, SSI transmits in accordance with + AC97 Frame Rate Divider bits - fsl,ssi-asynchronous: If specified, the SSI is to be programmed in asynchronous mode. In this mode, pins SRCK, STCK, SRFS, and STFS must
Add devicetree bindings documentation for operating SSI in AC'97 variable/fixed mode of operation. Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> --- Documentation/devicetree/bindings/sound/fsl,ssi.txt | 5 +++++ 1 file changed, 5 insertions(+)