[01/10] scsi: don't export scsi_device_from_queue

Message ID 20201005084130.143273-2-hch@lst.de
State New
Headers show
Series
  • [01/10] scsi: don't export scsi_device_from_queue
Related show

Commit Message

Christoph Hellwig Oct. 5, 2020, 8:41 a.m.
This function is only used by code built into scsi_mod.ko.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/scsi/scsi_lib.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Hannes Reinecke Oct. 5, 2020, 9 a.m. | #1
On 10/5/20 10:41 AM, Christoph Hellwig wrote:
> This function is only used by code built into scsi_mod.ko.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   drivers/scsi/scsi_lib.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index f0ee11dc07e4b0..b95e00ff346b09 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1959,7 +1959,6 @@ struct scsi_device *scsi_device_from_queue(struct request_queue *q)
>   
>   	return sdev;
>   }
> -EXPORT_SYMBOL_GPL(scsi_device_from_queue);
>   
>   /**
>    * scsi_block_requests - Utility function used by low-level drivers to prevent
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
Martin K. Petersen Oct. 13, 2020, 10:42 p.m. | #2
On Mon, 5 Oct 2020 10:41:21 +0200, Christoph Hellwig wrote:

> This function is only used by code built into scsi_mod.ko.

Applied to 5.10/scsi-queue, thanks!

[01/10] scsi: core: Don't export scsi_device_from_queue()
        https://git.kernel.org/mkp/scsi/c/2ba87c43872f
[02/10] scsi: core: Remove scsi_init_cmd_errh
        https://git.kernel.org/mkp/scsi/c/3a8dc5bbc8c0
[03/10] scsi: core: Move command size detection out of the fast path
        https://git.kernel.org/mkp/scsi/c/2ceda20f0a99
[05/10] scsi: core: Use rq_dma_dir in scsi_setup_cmnd()
        https://git.kernel.org/mkp/scsi/c/40b93836a136
[06/10] scsi: core: Rename scsi_prep_state_check() to scsi_device_state_check()
        https://git.kernel.org/mkp/scsi/c/822bd2db798b
[07/10] scsi: core: Rename scsi_mq_prep_fn() to scsi_prepare_cmd()
        https://git.kernel.org/mkp/scsi/c/5843cc3d5acd
[08/10] scsi: core: Clean up allocation and freeing of sgtables
        https://git.kernel.org/mkp/scsi/c/7007e9dd5676
[09/10] scsi: core: Remove scsi_setup_cmnd() and scsi_setup_fs_cmnd()
        https://git.kernel.org/mkp/scsi/c/74e5e6c1b18c
[10/10] scsi: core: Only start the request just before dispatching
        https://git.kernel.org/mkp/scsi/c/ed7fb2d018fd

Patch

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index f0ee11dc07e4b0..b95e00ff346b09 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1959,7 +1959,6 @@  struct scsi_device *scsi_device_from_queue(struct request_queue *q)
 
 	return sdev;
 }
-EXPORT_SYMBOL_GPL(scsi_device_from_queue);
 
 /**
  * scsi_block_requests - Utility function used by low-level drivers to prevent