| Message ID | 20201007084557.25843-22-sakari.ailus@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
Em Wed, 7 Oct 2020 11:44:42 +0300 Sakari Ailus <sakari.ailus@linux.intel.com> escreveu: > The I²C ID table is no longer needed; remove it. Why not? Please provide more information. In summary, please change the description in order to answer the following questions: For OF-based drivers, removing I2C probing won't cause any harm, as the patch is keeping css_of_able, but wouldn't it affect other drivers that could, for example, be using ACPI, instead? Or is this driver incompatible with other probing methods? > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/media/i2c/ccs/ccs-core.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c > index e348f55c62a6..660d5ab2c89d 100644 > --- a/drivers/media/i2c/ccs/ccs-core.c > +++ b/drivers/media/i2c/ccs/ccs-core.c > @@ -3244,12 +3244,6 @@ static const struct of_device_id ccs_of_table[] = { > }; > MODULE_DEVICE_TABLE(of, ccs_of_table); > > -static const struct i2c_device_id ccs_id_table[] = { > - { SMIAPP_NAME, 0 }, > - { }, > -}; > -MODULE_DEVICE_TABLE(i2c, ccs_id_table); > - > static const struct dev_pm_ops ccs_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(ccs_suspend, ccs_resume) > SET_RUNTIME_PM_OPS(ccs_power_off, ccs_power_on, NULL) > @@ -3263,7 +3257,6 @@ static struct i2c_driver ccs_i2c_driver = { > }, > .probe_new = ccs_probe, > .remove = ccs_remove, > - .id_table = ccs_id_table, > }; > > static int ccs_module_init(void) Thanks, Mauro
Hi Mauro, On Thu, Nov 05, 2020 at 10:34:45AM +0100, Mauro Carvalho Chehab wrote: > Em Wed, 7 Oct 2020 11:44:42 +0300 > Sakari Ailus <sakari.ailus@linux.intel.com> escreveu: > > > The I²C ID table is no longer needed; remove it. > > Why not? Please provide more information. > > In summary, please change the description in order to answer the > following questions: > > For OF-based drivers, removing I2C probing won't cause any harm, > as the patch is keeping css_of_able, but wouldn't it affect other > drivers that could, for example, be using ACPI, instead? > > Or is this driver incompatible with other probing methods? ACPI doesn't need this anymore. It did though. Platform data support has been (gradually) removed so I believe this can be removed, too. If someone can show it has a purpose, I don't have objections to reverting this later either. -- Regards, Sakari Ailus
diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c index e348f55c62a6..660d5ab2c89d 100644 --- a/drivers/media/i2c/ccs/ccs-core.c +++ b/drivers/media/i2c/ccs/ccs-core.c @@ -3244,12 +3244,6 @@ static const struct of_device_id ccs_of_table[] = { }; MODULE_DEVICE_TABLE(of, ccs_of_table); -static const struct i2c_device_id ccs_id_table[] = { - { SMIAPP_NAME, 0 }, - { }, -}; -MODULE_DEVICE_TABLE(i2c, ccs_id_table); - static const struct dev_pm_ops ccs_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(ccs_suspend, ccs_resume) SET_RUNTIME_PM_OPS(ccs_power_off, ccs_power_on, NULL) @@ -3263,7 +3257,6 @@ static struct i2c_driver ccs_i2c_driver = { }, .probe_new = ccs_probe, .remove = ccs_remove, - .id_table = ccs_id_table, }; static int ccs_module_init(void)
The I²C ID table is no longer needed; remove it. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/i2c/ccs/ccs-core.c | 7 ------- 1 file changed, 7 deletions(-)