| Message ID | 1602160344-19586-4-git-send-email-gokulsri@codeaurora.org |
|---|---|
| State | New |
| Headers | show |
| Series | Add board support for HK10 board variants | expand |
Hi, On Thu, Oct 08, 2020 at 06:02:24PM +0530, Gokul Sriram Palanisamy wrote: > Enabled MHI device support over PCIe and added memory > reservation required for MHI enabled QCN9000 PCIe card. > > Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47 ++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > index 0827055..e5c1ec0 100644 > --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > @@ -24,6 +24,22 @@ > device_type = "memory"; > reg = <0x0 0x40000000 0x0 0x20000000>; > }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + qcn9000_pcie0: memory@50f00000 { > + no-map; > + reg = <0x0 0x50f00000 0x0 0x03700000>; > + }; > + > + qcn9000_pcie1: memory@54600000 { > + no-map; > + reg = <0x0 0x54600000 0x0 0x03700000>; > + }; > + }; > }; > > &blsp1_spi1 { > @@ -45,11 +61,42 @@ > &pcie0 { > status = "ok"; > perst-gpio = <&tlmm 58 0x1>; > + > + pcie0_rp: pcie0_rp { > + reg = <0 0 0 0 0>; > + > + status = "ok"; > + mhi_0: qcom,mhi@0 { MHI doesn't support devicetree as of now so how is this supposed to work? Have you tested this series with mainline? Thanks, Mani > + reg = <0 0 0 0 0 >; > + > + qrtr_instance_id = <0x20>; > + base-addr = <0x50f00000>; > + m3-dump-addr = <0x53c00000>; > + etr-addr = <0x53d00000>; > + qcom,caldb-addr = <0x53e00000>; > + }; > + }; > }; > > &pcie1 { > status = "ok"; > perst-gpio = <&tlmm 61 0x1>; > + > + pcie1_rp: pcie1_rp { > + reg = <0 0 0 0 0>; > + > + status = "ok"; > + mhi_1: qcom,mhi@1 { > + reg = <0 0 0 0 0 >; > + > + qrtr_instance_id = <0x21>; > + base-addr = <0x54600000>; > + m3-dump-addr = <0x57300000>; > + etr-addr = <0x57400000>; > + qcom,caldb-addr = <0x57500000>; > + }; > + }; > + }; > }; > > &qmp_pcie_phy0 { > -- > 2.7.4 >
On 2020-10-08 18:41, Manivannan Sadhasivam wrote: > Hi, > > On Thu, Oct 08, 2020 at 06:02:24PM +0530, Gokul Sriram Palanisamy > wrote: >> Enabled MHI device support over PCIe and added memory >> reservation required for MHI enabled QCN9000 PCIe card. >> >> Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47 >> ++++++++++++++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi >> b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi >> index 0827055..e5c1ec0 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi >> @@ -24,6 +24,22 @@ >> device_type = "memory"; >> reg = <0x0 0x40000000 0x0 0x20000000>; >> }; >> + >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + qcn9000_pcie0: memory@50f00000 { >> + no-map; >> + reg = <0x0 0x50f00000 0x0 0x03700000>; >> + }; >> + >> + qcn9000_pcie1: memory@54600000 { >> + no-map; >> + reg = <0x0 0x54600000 0x0 0x03700000>; >> + }; >> + }; >> }; >> >> &blsp1_spi1 { >> @@ -45,11 +61,42 @@ >> &pcie0 { >> status = "ok"; >> perst-gpio = <&tlmm 58 0x1>; >> + >> + pcie0_rp: pcie0_rp { >> + reg = <0 0 0 0 0>; >> + >> + status = "ok"; >> + mhi_0: qcom,mhi@0 { > > MHI doesn't support devicetree as of now so how is this supposed to > work? > Have you tested this series with mainline? > > Thanks, > Mani > Hi Mani, This node entries will be consumed by ath11k driver and is not supposed to be consumed by mhi driver. And yes, it is tested on Mainline. Regards, Gokul >> + reg = <0 0 0 0 0 >; >> + >> + qrtr_instance_id = <0x20>; >> + base-addr = <0x50f00000>; >> + m3-dump-addr = <0x53c00000>; >> + etr-addr = <0x53d00000>; >> + qcom,caldb-addr = <0x53e00000>; >> + }; >> + }; >> }; >> >> &pcie1 { >> status = "ok"; >> perst-gpio = <&tlmm 61 0x1>; >> + >> + pcie1_rp: pcie1_rp { >> + reg = <0 0 0 0 0>; >> + >> + status = "ok"; >> + mhi_1: qcom,mhi@1 { >> + reg = <0 0 0 0 0 >; >> + >> + qrtr_instance_id = <0x21>; >> + base-addr = <0x54600000>; >> + m3-dump-addr = <0x57300000>; >> + etr-addr = <0x57400000>; >> + qcom,caldb-addr = <0x57500000>; >> + }; >> + }; >> + }; >> }; >> >> &qmp_pcie_phy0 { >> -- >> 2.7.4 >>
Hi Gokul,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.9-rc8]
[cannot apply to next-20201008]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gokul-Sriram-Palanisamy/Add-board-support-for-HK10-board-variants/20201008-203356
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r006-20201008 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d852c07655e85bfc07d8d3543698ce06e2ce62f8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gokul-Sriram-Palanisamy/Add-board-support-for-HK10-board-variants/20201008-203356
git checkout d852c07655e85bfc07d8d3543698ce06e2ce62f8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi:100.1-2 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi Gokul,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.9-rc8]
[cannot apply to next-20201008]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gokul-Sriram-Palanisamy/Add-board-support-for-HK10-board-variants/20201008-203356
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r015-20201008 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 8da0df3d6dcc0dd42740be60b0da4ec201190904)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/d852c07655e85bfc07d8d3543698ce06e2ce62f8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gokul-Sriram-Palanisamy/Add-board-support-for-HK10-board-variants/20201008-203356
git checkout d852c07655e85bfc07d8d3543698ce06e2ce62f8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi:100.1-2 syntax error
>> FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
On Thu, Oct 08, 2020 at 11:03:42PM +0530, gokulsri@codeaurora.org wrote: > On 2020-10-08 18:41, Manivannan Sadhasivam wrote: > > Hi, > > > > On Thu, Oct 08, 2020 at 06:02:24PM +0530, Gokul Sriram Palanisamy wrote: > > > Enabled MHI device support over PCIe and added memory > > > reservation required for MHI enabled QCN9000 PCIe card. > > > > > > Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org> > > > --- > > > arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47 > > > ++++++++++++++++++++++++++++++ > > > 1 file changed, 47 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > > > b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > > > index 0827055..e5c1ec0 100644 > > > --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi [...] > > > + pcie0_rp: pcie0_rp { > > > + reg = <0 0 0 0 0>; > > > + > > > + status = "ok"; > > > + mhi_0: qcom,mhi@0 { > > > > MHI doesn't support devicetree as of now so how is this supposed to > > work? > > Have you tested this series with mainline? > > > > Thanks, > > Mani > > > > Hi Mani, > This node entries will be consumed by ath11k driver and is not supposed to > be consumed by mhi driver. > And yes, it is tested on Mainline. > Can you please point me to the relevant binding or the code which consumes this change? Also please explain what it does! For enabling MHI support over PCIe you don't need this node at all. You just need to define the PCIe device ID in the ath11k driver and that's it. Adding Kalle to this thread... Thanks, Mani > Regards, > Gokul > > > > + reg = <0 0 0 0 0 >; > > > + > > > + qrtr_instance_id = <0x20>; > > > + base-addr = <0x50f00000>; > > > + m3-dump-addr = <0x53c00000>; > > > + etr-addr = <0x53d00000>; > > > + qcom,caldb-addr = <0x53e00000>; > > > + }; > > > + }; > > > }; > > > > > > &pcie1 { > > > status = "ok"; > > > perst-gpio = <&tlmm 61 0x1>; > > > + > > > + pcie1_rp: pcie1_rp { > > > + reg = <0 0 0 0 0>; > > > + > > > + status = "ok"; > > > + mhi_1: qcom,mhi@1 { > > > + reg = <0 0 0 0 0 >; > > > + > > > + qrtr_instance_id = <0x21>; > > > + base-addr = <0x54600000>; > > > + m3-dump-addr = <0x57300000>; > > > + etr-addr = <0x57400000>; > > > + qcom,caldb-addr = <0x57500000>; > > > + }; > > > + }; > > > + }; > > > }; > > > > > > &qmp_pcie_phy0 { > > > -- > > > 2.7.4 > > >
+ ath11k list Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes: > On Thu, Oct 08, 2020 at 11:03:42PM +0530, gokulsri@codeaurora.org wrote: >> On 2020-10-08 18:41, Manivannan Sadhasivam wrote: >> > Hi, >> > >> > On Thu, Oct 08, 2020 at 06:02:24PM +0530, Gokul Sriram Palanisamy wrote: >> > > Enabled MHI device support over PCIe and added memory >> > > reservation required for MHI enabled QCN9000 PCIe card. >> > > >> > > Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org> >> > > --- >> > > arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47 >> > > ++++++++++++++++++++++++++++++ >> > > 1 file changed, 47 insertions(+) >> > > >> > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi >> > > b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi >> > > index 0827055..e5c1ec0 100644 >> > > --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi >> > > +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > > [...] > >> > > + pcie0_rp: pcie0_rp { >> > > + reg = <0 0 0 0 0>; >> > > + >> > > + status = "ok"; >> > > + mhi_0: qcom,mhi@0 { >> > >> > MHI doesn't support devicetree as of now so how is this supposed to >> > work? >> > Have you tested this series with mainline? >> > >> > Thanks, >> > Mani >> > >> >> Hi Mani, >> This node entries will be consumed by ath11k driver and is not supposed to >> be consumed by mhi driver. >> And yes, it is tested on Mainline. Upstream ath11k does not yet support QCN9074 so I don't see how this is tested with mainline ath11k. You must be using some out-of-tree _unofficial_ ath11k patches. > Can you please point me to the relevant binding or the code which consumes this > change? > > Also please explain what it does! For enabling MHI support over PCIe you don't > need this node at all. You just need to define the PCIe device ID in the ath11k > driver and that's it. > > Adding Kalle to this thread... So currently QCN9074 firmware needs 55 MB of contiguous host memory and I suspect one reason for these DT entries is an ugly hack to provide that memory range to the firmware. We are currently preparing QCN9074 patches for ath11k and finding a solution how to implement these properly in ath11k. Hopefully there's no need for hacks like this, we know more once we get the ath11k QCN9074 patches ready. Please drop this patch.
diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi index 0827055..e5c1ec0 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi @@ -24,6 +24,22 @@ device_type = "memory"; reg = <0x0 0x40000000 0x0 0x20000000>; }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + qcn9000_pcie0: memory@50f00000 { + no-map; + reg = <0x0 0x50f00000 0x0 0x03700000>; + }; + + qcn9000_pcie1: memory@54600000 { + no-map; + reg = <0x0 0x54600000 0x0 0x03700000>; + }; + }; }; &blsp1_spi1 { @@ -45,11 +61,42 @@ &pcie0 { status = "ok"; perst-gpio = <&tlmm 58 0x1>; + + pcie0_rp: pcie0_rp { + reg = <0 0 0 0 0>; + + status = "ok"; + mhi_0: qcom,mhi@0 { + reg = <0 0 0 0 0 >; + + qrtr_instance_id = <0x20>; + base-addr = <0x50f00000>; + m3-dump-addr = <0x53c00000>; + etr-addr = <0x53d00000>; + qcom,caldb-addr = <0x53e00000>; + }; + }; }; &pcie1 { status = "ok"; perst-gpio = <&tlmm 61 0x1>; + + pcie1_rp: pcie1_rp { + reg = <0 0 0 0 0>; + + status = "ok"; + mhi_1: qcom,mhi@1 { + reg = <0 0 0 0 0 >; + + qrtr_instance_id = <0x21>; + base-addr = <0x54600000>; + m3-dump-addr = <0x57300000>; + etr-addr = <0x57400000>; + qcom,caldb-addr = <0x57500000>; + }; + }; + }; }; &qmp_pcie_phy0 {
Enabled MHI device support over PCIe and added memory reservation required for MHI enabled QCN9000 PCIe card. Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org> --- arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47 ++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)