| Message ID | 20201014075523.15688-1-qiang.zhang@windriver.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: gadget: function: printer: Fix usb function descriptors leak | expand |
On Wed, Oct 14, 2020 at 03:55:23PM +0800, Zqiang wrote: > If an error occurs after call 'usb_assign_descriptors' func, the > 'usb_free_all_descriptors' need to be call to release memory space > occupied by function descriptors. > > Signed-off-by: Zqiang <qiang.zhang@windriver.com> Please use your ful name for the From: and signed-off-by lines, as the documentation states is required. If this is your full name, then why does it not match the name on your email address from your employer? > --- > drivers/usb/gadget/function/f_printer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c > index 64a4112068fc..2f1eb2e81d30 100644 > --- a/drivers/usb/gadget/function/f_printer.c > +++ b/drivers/usb/gadget/function/f_printer.c > @@ -1162,6 +1162,7 @@ static int printer_func_bind(struct usb_configuration *c, > printer_req_free(dev->in_ep, req); > } > > + usb_free_all_descriptors(f); What commit caused this problem? thanks, greg k-h
diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c index 64a4112068fc..2f1eb2e81d30 100644 --- a/drivers/usb/gadget/function/f_printer.c +++ b/drivers/usb/gadget/function/f_printer.c @@ -1162,6 +1162,7 @@ static int printer_func_bind(struct usb_configuration *c, printer_req_free(dev->in_ep, req); } + usb_free_all_descriptors(f); return ret; }
If an error occurs after call 'usb_assign_descriptors' func, the 'usb_free_all_descriptors' need to be call to release memory space occupied by function descriptors. Signed-off-by: Zqiang <qiang.zhang@windriver.com> --- drivers/usb/gadget/function/f_printer.c | 1 + 1 file changed, 1 insertion(+)