diff mbox

[Xen-devel,21/34] xen/common: domctl: Some functions are only used internally

Message ID 1395766541-23979-22-git-send-email-julien.grall@linaro.org
State Accepted, archived
Headers show

Commit Message

Julien Grall March 25, 2014, 4:55 p.m. UTC
The list of function above are only used internally in common/domctl.c.
    - bitmap_to_xenctl_bitmap
    - xenctl_bitmap_to_bitmap
    - nodemask_to_xenctl_bitmap
    - xenctl_bitmap_to_nodemask

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Cc: Keir Fraser <keir@xen.org>
---
 xen/common/domctl.c |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Keir Fraser April 1, 2014, 5:40 p.m. UTC | #1
On Tue, Mar 25, 2014 at 4:55 PM, Julien Grall <julien.grall@linaro.org>wrote:

> The list of function above are only used internally in common/domctl.c.
>     - bitmap_to_xenctl_bitmap
>     - xenctl_bitmap_to_bitmap
>     - nodemask_to_xenctl_bitmap
>     - xenctl_bitmap_to_nodemask
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Cc: Keir Fraser <keir@xen.org>
>

Acked-by: Keir Fraser <keir@xen.org>


> ---
>  xen/common/domctl.c |   20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index 7cf610a..5342e5d 100644
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -33,9 +33,9 @@
>  static DEFINE_SPINLOCK(domctl_lock);
>  DEFINE_SPINLOCK(vcpu_alloc_lock);
>
> -int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap,
> -                            const unsigned long *bitmap,
> -                            unsigned int nbits)
> +static int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap,
> +                                   const unsigned long *bitmap,
> +                                   unsigned int nbits)
>  {
>      unsigned int guest_bytes, copy_bytes, i;
>      uint8_t zero = 0;
> @@ -63,9 +63,9 @@ int bitmap_to_xenctl_bitmap(struct xenctl_bitmap
> *xenctl_bitmap,
>      return err;
>  }
>
> -int xenctl_bitmap_to_bitmap(unsigned long *bitmap,
> -                            const struct xenctl_bitmap *xenctl_bitmap,
> -                            unsigned int nbits)
> +static int xenctl_bitmap_to_bitmap(unsigned long *bitmap,
> +                                   const struct xenctl_bitmap
> *xenctl_bitmap,
> +                                   unsigned int nbits)
>  {
>      unsigned int guest_bytes, copy_bytes;
>      int err = 0;
> @@ -118,15 +118,15 @@ int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask,
>      return err;
>  }
>
> -int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap,
> -                              const nodemask_t *nodemask)
> +static int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap,
> +                                     const nodemask_t *nodemask)
>  {
>      return bitmap_to_xenctl_bitmap(xenctl_nodemap, nodes_addr(*nodemask),
>                                     MAX_NUMNODES);
>  }
>
> -int xenctl_bitmap_to_nodemask(nodemask_t *nodemask,
> -                              const struct xenctl_bitmap *xenctl_nodemap)
> +static int xenctl_bitmap_to_nodemask(nodemask_t *nodemask,
> +                                     const struct xenctl_bitmap
> *xenctl_nodemap)
>  {
>      return xenctl_bitmap_to_bitmap(nodes_addr(*nodemask), xenctl_nodemap,
>                                     MAX_NUMNODES);
> --
> 1.7.10.4
>
>
diff mbox

Patch

diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 7cf610a..5342e5d 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -33,9 +33,9 @@ 
 static DEFINE_SPINLOCK(domctl_lock);
 DEFINE_SPINLOCK(vcpu_alloc_lock);
 
-int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap,
-                            const unsigned long *bitmap,
-                            unsigned int nbits)
+static int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap,
+                                   const unsigned long *bitmap,
+                                   unsigned int nbits)
 {
     unsigned int guest_bytes, copy_bytes, i;
     uint8_t zero = 0;
@@ -63,9 +63,9 @@  int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap,
     return err;
 }
 
-int xenctl_bitmap_to_bitmap(unsigned long *bitmap,
-                            const struct xenctl_bitmap *xenctl_bitmap,
-                            unsigned int nbits)
+static int xenctl_bitmap_to_bitmap(unsigned long *bitmap,
+                                   const struct xenctl_bitmap *xenctl_bitmap,
+                                   unsigned int nbits)
 {
     unsigned int guest_bytes, copy_bytes;
     int err = 0;
@@ -118,15 +118,15 @@  int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask,
     return err;
 }
 
-int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap,
-                              const nodemask_t *nodemask)
+static int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap,
+                                     const nodemask_t *nodemask)
 {
     return bitmap_to_xenctl_bitmap(xenctl_nodemap, nodes_addr(*nodemask),
                                    MAX_NUMNODES);
 }
 
-int xenctl_bitmap_to_nodemask(nodemask_t *nodemask,
-                              const struct xenctl_bitmap *xenctl_nodemap)
+static int xenctl_bitmap_to_nodemask(nodemask_t *nodemask,
+                                     const struct xenctl_bitmap *xenctl_nodemap)
 {
     return xenctl_bitmap_to_bitmap(nodes_addr(*nodemask), xenctl_nodemap,
                                    MAX_NUMNODES);