diff mbox series

[RFC] hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

Message ID 20201019091508.197-1-yuzenghui@huawei.com
State Accepted
Commit a55aab618163f9ffd8b5cbf737d4e57875264510
Headers show
Series [RFC] hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly | expand

Commit Message

Zenghui Yu Oct. 19, 2020, 9:15 a.m. UTC
Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA
translation can work properly during migration.

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---

not sure if anything would actually go wrong...

 hw/arm/smmuv3.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Eric Auger Oct. 26, 2020, 5:03 p.m. UTC | #1
Hi Zenghui,

On 10/19/20 11:15 AM, Zenghui Yu wrote:
> Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA

> translation can work properly during migration.


Sorry I missed this patch. good catch!

Acked-by: Eric Auger <eric.auger@redhat.com>


Thanks

Eric

> 

> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>

> ---

> 

> not sure if anything would actually go wrong...

> 

>  hw/arm/smmuv3.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c

> index 0122700e72..2017ba7a5a 100644

> --- a/hw/arm/smmuv3.c

> +++ b/hw/arm/smmuv3.c

> @@ -1440,6 +1440,7 @@ static const VMStateDescription vmstate_smmuv3 = {

>      .name = "smmuv3",

>      .version_id = 1,

>      .minimum_version_id = 1,

> +    .priority = MIG_PRI_IOMMU,

>      .fields = (VMStateField[]) {

>          VMSTATE_UINT32(features, SMMUv3State),

>          VMSTATE_UINT8(sid_size, SMMUv3State),

>
Peter Maydell Oct. 26, 2020, 5:16 p.m. UTC | #2
On Mon, 26 Oct 2020 at 17:03, Auger Eric <eric.auger@redhat.com> wrote:
>
> Hi Zenghui,
>
> On 10/19/20 11:15 AM, Zenghui Yu wrote:
> > Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA
> > translation can work properly during migration.
>
> Sorry I missed this patch. good catch!
>
> Acked-by: Eric Auger <eric.auger@redhat.com>



Applied to target-arm.next, thanks.

-- PMM
diff mbox series

Patch

diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
index 0122700e72..2017ba7a5a 100644
--- a/hw/arm/smmuv3.c
+++ b/hw/arm/smmuv3.c
@@ -1440,6 +1440,7 @@  static const VMStateDescription vmstate_smmuv3 = {
     .name = "smmuv3",
     .version_id = 1,
     .minimum_version_id = 1,
+    .priority = MIG_PRI_IOMMU,
     .fields = (VMStateField[]) {
         VMSTATE_UINT32(features, SMMUv3State),
         VMSTATE_UINT8(sid_size, SMMUv3State),