| Message ID | 20201009113843.60995-1-lvivier@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] hw/char/serial: remove duplicate .class_init in serial_mm_info | expand |
On 10/9/20 1:38 PM, Laurent Vivier wrote: > .class_init is already set to serial_mm_class_init. > > Remove the duplicate entry. > > Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property") > Cc: marcandre.lureau@redhat.com I was going to send exactly the same one tomorrow =) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > hw/char/serial.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index 4386adabd466..97f71879ff2a 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = { > .class_init = serial_mm_class_init, > .instance_init = serial_mm_instance_init, > .instance_size = sizeof(SerialMM), > - .class_init = serial_mm_class_init, > }; > > static void serial_register_types(void) >
Laurent Vivier <lvivier@redhat.com> 于2020年10月9日周五 下午7:40写道： > > .class_init is already set to serial_mm_class_init. > > Remove the duplicate entry. > > Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property") > Cc: marcandre.lureau@redhat.com > Signed-off-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > hw/char/serial.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index 4386adabd466..97f71879ff2a 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = { > .class_init = serial_mm_class_init, > .instance_init = serial_mm_instance_init, > .instance_size = sizeof(SerialMM), > - .class_init = serial_mm_class_init, > }; > > static void serial_register_types(void) > -- > 2.26.2 > >
On Fri, Oct 9, 2020 at 4:39 AM Laurent Vivier <lvivier@redhat.com> wrote: > > .class_init is already set to serial_mm_class_init. > > Remove the duplicate entry. > > Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property") > Cc: marcandre.lureau@redhat.com > Signed-off-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/char/serial.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index 4386adabd466..97f71879ff2a 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = { > .class_init = serial_mm_class_init, > .instance_init = serial_mm_instance_init, > .instance_size = sizeof(SerialMM), > - .class_init = serial_mm_class_init, > }; > > static void serial_register_types(void) > -- > 2.26.2 > >
Le 09/10/2020 à 13:38, Laurent Vivier a écrit : > .class_init is already set to serial_mm_class_init. > > Remove the duplicate entry. > > Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property") > Cc: marcandre.lureau@redhat.com > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > hw/char/serial.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index 4386adabd466..97f71879ff2a 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = { > .class_init = serial_mm_class_init, > .instance_init = serial_mm_instance_init, > .instance_size = sizeof(SerialMM), > - .class_init = serial_mm_class_init, > }; > > static void serial_register_types(void) > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/char/serial.c b/hw/char/serial.c index 4386adabd466..97f71879ff2a 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = { .class_init = serial_mm_class_init, .instance_init = serial_mm_instance_init, .instance_size = sizeof(SerialMM), - .class_init = serial_mm_class_init, }; static void serial_register_types(void)
.class_init is already set to serial_mm_class_init. Remove the duplicate entry. Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property") Cc: marcandre.lureau@redhat.com Signed-off-by: Laurent Vivier <lvivier@redhat.com> --- hw/char/serial.c | 1 - 1 file changed, 1 deletion(-)