| Message ID | 20201008110148.2757734-1-misono.tomohiro@jp.fujitsu.com |
|---|---|
| State | Accepted |
| Commit | 800ad114f10d0bf94e49b1441e1a13064a45a967 |
| Headers | show |
| Series | virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level | expand |
On Thu, Oct 08, 2020 at 08:01:48PM +0900, Misono Tomohiro wrote: > Just noticed that although help message says default log level is INFO, > it is actually 0 (EMRGE) and no mesage will be shown when error occurs. > It's better to follow help message. > > Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> > --- > tools/virtiofsd/passthrough_ll.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) I checked that FUSE_LOG_INFO isn't used in the main request code path. Therefore this change shouldn't cause a lot of new log output or affect performance: Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
* Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote: > Just noticed that although help message says default log level is INFO, > it is actually 0 (EMRGE) and no mesage will be shown when error occurs. > It's better to follow help message. > > Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> Queued > --- > tools/virtiofsd/passthrough_ll.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c > index 0b229ebd57..4ff9f1b688 100644 > --- a/tools/virtiofsd/passthrough_ll.c > +++ b/tools/virtiofsd/passthrough_ll.c > @@ -2888,12 +2888,11 @@ int main(int argc, char *argv[]) > goto err_out1; > } > > - /* > - * log_level is 0 if not configured via cmd options (0 is LOG_EMERG, > - * and we don't use this log level). > - */ > if (opts.log_level != 0) { > current_log_level = opts.log_level; > + } else { > + /* default log level is INFO */ > + current_log_level = FUSE_LOG_INFO; > } > lo.debug = opts.debug; > if (lo.debug) { > -- > 2.25.4 > >
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index 0b229ebd57..4ff9f1b688 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -2888,12 +2888,11 @@ int main(int argc, char *argv[]) goto err_out1; } - /* - * log_level is 0 if not configured via cmd options (0 is LOG_EMERG, - * and we don't use this log level). - */ if (opts.log_level != 0) { current_log_level = opts.log_level; + } else { + /* default log level is INFO */ + current_log_level = FUSE_LOG_INFO; } lo.debug = opts.debug; if (lo.debug) {
Just noticed that although help message says default log level is INFO, it is actually 0 (EMRGE) and no mesage will be shown when error occurs. It's better to follow help message. Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> --- tools/virtiofsd/passthrough_ll.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)