diff mbox series

[v2,2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3

Message ID 20201007100732.4103790-3-graeme@nuviainc.com
State Superseded
Headers show
Series hw/arm/sbsa-ref : small fixes to smmuv3 initialisation | expand

Commit Message

Graeme Gregory Oct. 7, 2020, 10:07 a.m. UTC
Original commit did not allocate IRQs for the SMMUv3 in the irqmap
effectively using irq 0->3 (shared with other devices). Assuming
original intent was to allocate unique IRQs then add an allocation
to the irqmap.

Fixes: e9fdf453240 ("hw/arm: Add arm SBSA reference machine, devices part")
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Graeme Gregory <graeme@nuviainc.com>
---
 hw/arm/sbsa-ref.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Philippe Mathieu-Daudé Oct. 7, 2020, 10:25 a.m. UTC | #1
On 10/7/20 12:07 PM, Graeme Gregory wrote:
> Original commit did not allocate IRQs for the SMMUv3 in the irqmap

> effectively using irq 0->3 (shared with other devices). Assuming

> original intent was to allocate unique IRQs then add an allocation

> to the irqmap.

> 

> Fixes: e9fdf453240 ("hw/arm: Add arm SBSA reference machine, devices part")

> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


Previous version also has:
Reviewed-by: Eric Auger <eric.auger@redhat.com>


> Signed-off-by: Graeme Gregory <graeme@nuviainc.com>

> ---

>  hw/arm/sbsa-ref.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c

> index 65e64883b5..01863510d0 100644

> --- a/hw/arm/sbsa-ref.c

> +++ b/hw/arm/sbsa-ref.c

> @@ -133,6 +133,7 @@ static const int sbsa_ref_irqmap[] = {

>      [SBSA_SECURE_UART_MM] = 9,

>      [SBSA_AHCI] = 10,

>      [SBSA_EHCI] = 11,

> +    [SBSA_SMMU] = 12, /* ... to 15 */

>  };

>  

>  static uint64_t sbsa_ref_cpu_mp_affinity(SBSAMachineState *sms, int idx)

>
diff mbox series

Patch

diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index 65e64883b5..01863510d0 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -133,6 +133,7 @@  static const int sbsa_ref_irqmap[] = {
     [SBSA_SECURE_UART_MM] = 9,
     [SBSA_AHCI] = 10,
     [SBSA_EHCI] = 11,
+    [SBSA_SMMU] = 12, /* ... to 15 */
 };
 
 static uint64_t sbsa_ref_cpu_mp_affinity(SBSAMachineState *sms, int idx)