| Message ID | 20200918111632.37354-1-zhangguoqing.kernel@bytedance.com |
|---|---|
| State | New |
| Headers | show |
| Series | virtio-gpu-3d: fix abnormal display after a warm reboot | expand |
Patchew URL: https://patchew.org/QEMU/20200918111632.37354-1-zhangguoqing.kernel@bytedance.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200918111632.37354-1-zhangguoqing.kernel@bytedance.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200918111632.37354-1-zhangguoqing.kernel@bytedance.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is available at http://patchew.org/logs/20200918111632.37354-1-zhangguoqing.kernel@bytedance.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
hello Gerd and Michael Michael S. Tsirkin ping http://patchwork.ozlabs.org/project/qemu-devel/list/?series=202680 On Fri, Sep 18, 2020 at 7:16 PM Guoqing Zhang < zhangguoqing.kernel@bytedance.com> wrote: > When resetting virtio-gpu, virgl_renderer_reset() should be > called to ensure that the virglrenderer status is correct. > > Signed-off-by: Guoqing Zhang <zhangguoqing.kernel@bytedance.com> > Reviewed-by: Qi Liu<liuqi.16@bytedance.com> > --- > hw/display/virtio-gpu-3d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c > index 96621576c2..1bd33d7aed 100644 > --- a/hw/display/virtio-gpu-3d.c > +++ b/hw/display/virtio-gpu-3d.c > @@ -595,7 +595,7 @@ void virtio_gpu_virgl_reset(VirtIOGPU *g) > { > int i; > > - /* virgl_renderer_reset() ??? */ > + virgl_renderer_reset(); > for (i = 0; i < g->parent_obj.conf.max_outputs; i++) { > if (i != 0) { > dpy_gfx_replace_surface(g->parent_obj.scanout[i].con, NULL); > -- > 2.24.3 (Apple Git-128) > > <div dir="ltr"><div dir="ltr"><div>hello Gerd and Michael Michael S. Tsirkin </div><div><br></div>ping<div><br></div><div><a href="http://patchwork.ozlabs.org/project/qemu-devel/list/?series=202680">http://patchwork.ozlabs.org/project/qemu-devel/list/?series=202680</a><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 18, 2020 at 7:16 PM Guoqing Zhang <<a href="mailto:zhangguoqing.kernel@bytedance.com">zhangguoqing.kernel@bytedance.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">When resetting virtio-gpu, virgl_renderer_reset() should be<br> called to ensure that the virglrenderer status is correct.<br> <br> Signed-off-by: Guoqing Zhang <<a href="mailto:zhangguoqing.kernel@bytedance.com" target="_blank">zhangguoqing.kernel@bytedance.com</a>><br> Reviewed-by: Qi Liu<<a href="mailto:liuqi.16@bytedance.com" target="_blank">liuqi.16@bytedance.com</a>><br> ---<br> hw/display/virtio-gpu-3d.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c<br> index 96621576c2..1bd33d7aed 100644<br> --- a/hw/display/virtio-gpu-3d.c<br> +++ b/hw/display/virtio-gpu-3d.c<br> @@ -595,7 +595,7 @@ void virtio_gpu_virgl_reset(VirtIOGPU *g)<br> {<br> int i;<br> <br> - /* virgl_renderer_reset() ??? */<br> + virgl_renderer_reset();<br> for (i = 0; i < g->parent_obj.conf.max_outputs; i++) {<br> if (i != 0) {<br> dpy_gfx_replace_surface(g->parent_obj.scanout[i].con, NULL);<br> -- <br> 2.24.3 (Apple Git-128)<br> <br> </blockquote></div></div>
On Sun, Sep 27, 2020 at 08:17:10PM +0800, Guoqing Zhang wrote: > hello Gerd and Michael Michael S. Tsirkin > > ping Queued up now (not much activity for vga/ui these days ...). > > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=202680 > > On Fri, Sep 18, 2020 at 7:16 PM Guoqing Zhang < > zhangguoqing.kernel@bytedance.com> wrote: > > > When resetting virtio-gpu, virgl_renderer_reset() should be > > called to ensure that the virglrenderer status is correct. > > > > Signed-off-by: Guoqing Zhang <zhangguoqing.kernel@bytedance.com> > > Reviewed-by: Qi Liu<liuqi.16@bytedance.com> > > --- > > hw/display/virtio-gpu-3d.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c > > index 96621576c2..1bd33d7aed 100644 > > --- a/hw/display/virtio-gpu-3d.c > > +++ b/hw/display/virtio-gpu-3d.c > > @@ -595,7 +595,7 @@ void virtio_gpu_virgl_reset(VirtIOGPU *g) > > { > > int i; > > > > - /* virgl_renderer_reset() ??? */ > > + virgl_renderer_reset(); > > for (i = 0; i < g->parent_obj.conf.max_outputs; i++) { > > if (i != 0) { > > dpy_gfx_replace_surface(g->parent_obj.scanout[i].con, NULL); > > -- > > 2.24.3 (Apple Git-128) > > > >
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 96621576c2..1bd33d7aed 100644 --- a/hw/display/virtio-gpu-3d.c +++ b/hw/display/virtio-gpu-3d.c @@ -595,7 +595,7 @@ void virtio_gpu_virgl_reset(VirtIOGPU *g) { int i; - /* virgl_renderer_reset() ??? */ + virgl_renderer_reset(); for (i = 0; i < g->parent_obj.conf.max_outputs; i++) { if (i != 0) { dpy_gfx_replace_surface(g->parent_obj.scanout[i].con, NULL);