diff mbox

[Xen-devel] xen/arm: Remove GIC definitions in asm-arm/config.h

Message ID 1396448016-2123-1-git-send-email-julien.grall@linaro.org
State Accepted, archived
Headers show

Commit Message

Julien Grall April 2, 2014, 2:13 p.m. UTC
The GIC is not used anynore in assembly code.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
 xen/include/asm-arm/config.h |   11 -----------
 1 file changed, 11 deletions(-)

Comments

Ian Campbell April 2, 2014, 2:32 p.m. UTC | #1
On Wed, 2014-04-02 at 15:13 +0100, Julien Grall wrote:
> The GIC is not used anynore in assembly code.

"anymore" (will fix on commit)

> Signed-off-by: Julien Grall <julien.grall@linaro.org>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Good riddance.
Julien Grall April 8, 2014, 10:34 a.m. UTC | #2
Hi Ian,

On 04/02/2014 03:32 PM, Ian Campbell wrote:
> On Wed, 2014-04-02 at 15:13 +0100, Julien Grall wrote:
>> The GIC is not used anynore in assembly code.
> 
> "anymore" (will fix on commit)
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Good riddance.

Do you plan to commit the patch soon?

Regards,
Ian Campbell April 8, 2014, 3:24 p.m. UTC | #3
On Tue, 2014-04-08 at 11:34 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 04/02/2014 03:32 PM, Ian Campbell wrote:
> > On Wed, 2014-04-02 at 15:13 +0100, Julien Grall wrote:
> >> The GIC is not used anynore in assembly code.
> > 
> > "anymore" (will fix on commit)
> >> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > Good riddance.
> 
> Do you plan to commit the patch soon?

I've just done it.
diff mbox

Patch

diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
index 5b7b1a8..ef291ff 100644
--- a/xen/include/asm-arm/config.h
+++ b/xen/include/asm-arm/config.h
@@ -192,17 +192,6 @@  extern unsigned long frametable_virt_end;
 #define watchdog_disable() ((void)0)
 #define watchdog_enable()  ((void)0)
 
-#ifdef __ASSEMBLY__
-/* Board-specific: regs base address for the GIC
- * Theses constants are only intend to be used in assembly file
- * because the DT is not yet parsed.
- */
-#define GIC_DR_OFFSET 0x1000
-#define GIC_CR_OFFSET 0x2000
-#define GIC_HR_OFFSET 0x4000 /* Guess work http://lists.infradead.org/pipermail/linux-arm-kernel/2011-September/064219.html */
-#define GIC_VR_OFFSET 0x6000 /* Virtual Machine CPU interface) */
-#endif /* __ASSEMBLY__ */
-
 #endif /* __ARM_CONFIG_H__ */
 /*
  * Local variables: