| Message ID | 1396552029-21318-2-git-send-email-dslutz@verizon.com |
|---|---|
| State | Accepted |
| Commit | 28c8460abd6c453d46516c6396d42d667dc339b9 |
| Headers | show |
On 04/03/14 15:06, Don Slutz wrote: > From: Ian Campbell <ian.campbell@citrix.com> > > These should all be unsigned long long to match various variables used > in the > code, same as x86_64. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> I think I can add: Reviewed-by: Don Slutz <dslutz@verizon.com> And it I may also have forgotten to add: Signed-off-by: Don Slutz <dslutz@verizon.com> -Don Slutz > --- > tools/xentrace/xenctx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c > index 7275a00..47712ab 100644 > --- a/tools/xentrace/xenctx.c > +++ b/tools/xentrace/xenctx.c > @@ -57,8 +57,8 @@ typedef uint64_t guest_word_t; > #elif defined(__aarch64__) > #define NO_TRANSLATION > typedef uint64_t guest_word_t; > -#define FMT_32B_WORD "%08lx" > -#define FMT_64B_WORD "%016lx" > +#define FMT_32B_WORD "%08llx" > +#define FMT_64B_WORD "%016llx" > #endif > > struct symbol {
On Thu, 2014-04-03 at 16:53 -0400, Don Slutz wrote: > On 04/03/14 15:06, Don Slutz wrote: > > From: Ian Campbell <ian.campbell@citrix.com> > > > > These should all be unsigned long long to match various variables used > > in the > > code, same as x86_64. > > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > I think I can add: > > Reviewed-by: Don Slutz <dslutz@verizon.com> > > And it I may also have forgotten to add: > > Signed-off-by: Don Slutz <dslutz@verizon.com> I think S-o-b is something of a super-set of reviewed by, so I just added that one. S-o-b is correct when you are forwarding a patch from someone else, either via DCO (b) or (c), in this case (c) since you didn't modify the patch. Anyway, this seems to build on both classes of ARM so I've committed the entire thing. Thanks! Ian.
diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c index 7275a00..47712ab 100644 --- a/tools/xentrace/xenctx.c +++ b/tools/xentrace/xenctx.c @@ -57,8 +57,8 @@ typedef uint64_t guest_word_t; #elif defined(__aarch64__) #define NO_TRANSLATION typedef uint64_t guest_word_t; -#define FMT_32B_WORD "%08lx" -#define FMT_64B_WORD "%016lx" +#define FMT_32B_WORD "%08llx" +#define FMT_64B_WORD "%016llx" #endif struct symbol {